Destination Mysql: DV2 #36936
Merged
Destination Mysql: DV2 #36936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
2 times, most recently
from
8236517 to
2965541
Compare
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
from
2965541 to
f40161c
Compare
This was referenced Apr 12, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
from
f40161c to
129aa86
Compare
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
from
129aa86 to
c0b31d2
Compare
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
from
c0b31d2 to
94a3dc0
Compare
edgao
changed the base branch from
dv2/td_tests_allow_unsafe_cast_2
to
dv2/mysql_raw_tables
edgao
force-pushed
the
dv2/mysql_raw_tables
branch
from
7a3147d to
b15916f
Compare
edgao
force-pushed
the
dv2/mysql_raw_tables
branch
2 times, most recently
from
a8dc68e to
0a27153
Compare
This was referenced Apr 30, 2024
katmarkham
approved these changes
Apr 30, 2024
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
from
be73530 to
55e7bf2
Compare
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
from
55e7bf2 to
bdf95d2
Compare
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
from
bdf95d2 to
1dfc87d
Compare
edgao
force-pushed
the
dv2/td_tests_allow_unsafe_cast_2
branch
2 times, most recently
from
be36130 to
9bb61fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ported from #34609 to use the kotlin cdk.
As a reminder, we're not doing any safe_cast stuff for mysql. I ran some manual tests in the perf test workspace; see Slack for summary.
We're generating (basically) the same data types as legacy normalization. The only diffs are numbers changing from
float->decimal(38, 9)(float only has 32-bit precision, so was causing problems) and timestamps changing from text ->varchar(1024).Also we're adding new indexes - normalization was previously creating no indexes at all on the final table; we now have indexes on
(extracted_at, pk, cursor),(extracted_at), and(raw_id). Legacy normalization and dv2 both index the raw table on raw_id; dv2 also indexes onloaded_at, extracted_atandextracted_at.