Issue 3662: HTTP request source support 'csv type' response #3663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherifnada
suggested changes
May 27, 2021
There was a problem hiding this comment.
thanks @dmateusp ! one change requested and we are good to go
| ) -> Generator[AirbyteMessage, None, None]: | ||
| r = self._make_request(config) | ||
| if r.status_code != 200: | ||
| raise Exception(f"Request failed. {r.text}") | ||
|
|
||
| # need to eagerly fetch the json. | ||
| data = r.json() | ||
|
|
||
| if isinstance(data, list) and isinstance(data[0], list): |
There was a problem hiding this comment.
we should also verify len(data) > 0
There was a problem hiding this comment.
hey @sherifnada, I'm actually going to close this PR
I agree with @marcosmarxm that the responses from the US Census API are so unconventional that they would be better supported to a separate "Source"
tkorenko
added a commit
that referenced
this pull request
Dec 16, 2022
+ Changes 'deploy-docs-site' workflow and 'deploy_docusaurus' script so these two things are used for doc PR verification as well.
tkorenko
added a commit
that referenced
this pull request
Dec 16, 2022
tkorenko
added a commit
that referenced
this pull request
Dec 16, 2022
+ In "Docs PR check mode" stop before "yarn deploy"
tkorenko
added a commit
that referenced
this pull request
Dec 16, 2022
tkorenko
added a commit
that referenced
this pull request
Dec 16, 2022
+ Routes Slack notifications to '#docs' + Sets default value of SKIP_DEPLOY variable in deploy_docusaurus script
tkorenko
added a commit
that referenced
this pull request
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolves #3662
How
It implements the second solution described in the issue, if the response received by the HTTP Request Source is a list of lists, then it wraps the lists into
{"data": <list>}recordsPre-merge Checklist
Recommended reading order
test.javacomponent.ts