[airbyte-cdk] Fix tab delimiter configuration in CSV file type

[blarghmatey]

What

Describe what the change is solving
This fixes use of the tab (\t) delimiter for CSV based file sources

How

The tab delimiter is only allowed to be a single character long. In the web UI entering a literal tab character (\t) yields an escaped tab character (\\t) in the stored configuration. This ensures that the escaped tab character is passed through to the call for csv.register_dialect as the proper literal tab \t.

Recommended reading order

1. csv_format.py

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?
The end result is that after the CDK change is published and affected sources (e.g. source-s3) are updated then the existing bug of not allowing tab separated files will work again.

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Actions

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

• Community member? Grant edit access to maintainers (instructions)
• Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• Connector version is set to 0.0.1
  • Dockerfile has version 0.0.1
• Documentation updated
  • Connector's README.md
  • Connector's bootstrap.md. See description and examples
  • docs/integrations/<source or destination>/<name>.md including changelog with an entry for the initial version. See changelog example
  • docs/integrations/README.md

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• If new credentials are required for use in CI, add them to GSM. Instructions.

Updating a connector

Community member or Airbyter

• Grant edit access to maintainers (instructions)
• Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• If new credentials are required for use in CI, add them to GSM. Instructions.

Connector Generator

• Issue acceptance criteria met
• PR name follows PR naming conventions
• If adding a new generator, add it to the list of scaffold modules being tested
• The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:generateScaffolds then checking in your changes
• Documentation which references the generator is updated as needed

Updating the Python CDK

Airbyter

Before merging:

• Pull Request description explains what problem it is solving
• Code change is unit tested
• Build and my-py check pass
• Smoke test the change on at least one affected connector
  • On Github: Run this workflow, passing --use-local-cdk --name=source-<connector> as options
  • Locally: airbyte-ci connectors --use-local-cdk --name=source-<connector> test
• PR is reviewed and approved

After merging:

• Publish the CDK
  • The CDK does not follow proper semantic versioning. Choose minor if this the change has significant user impact or is a breaking change. Choose patch otherwise.
  • Write a thoughtful changelog message so we know what was updated.
• Merge the platform PR that was auto-created for updating the Connector Builder's CDK version
  • This step is optional if the change does not affect the connector builder or declarative connectors.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		Mar 12, 2024 1:52pm

[blarghmatey]

@marcosmarxm this is a follow-on to the changes from #35246

[blarghmatey]

cc @dtiesling

[marcosmarxm]

Thanks @blarghmatey I'm going to take a look today!

[marcosmarxm]

Can you bump the metadata version? This is a CDK change

[blarghmatey]

@marcosmarxm do you think it will be possible to get this merged and included in a patch release of source-s3 today?

[marcosmarxm]

@maxi297 need your help here. @blarghmatey I'm going try to get this done asap.

[blarghmatey]

Awesome, thanks! Let me know if there's anything I can help with.

[marcosmarxm]

@brianjlai can you take a look?

[brianjlai]

Change makes sense and lines up with how we corrected "\\t"/r"\t" into \t in an older PR for legacy S3.

Thanks for the contribution @blarghmatey !

[blarghmatey]

@marcosmarxm it looks like your requested change might need to be updated for this to merge? Once this merges, what needs to be done to get the change published in source-s3?

[marcosmarxm]

Running tests to get this merged. @brianjlai will handle the publish action to get this published.