Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python CDK: fix gradle task dependency #35609

Conversation

postamar
Copy link
Contributor

Ensures that :generateComponentManifestClassFiles gets triggered by :build like it used to prior to #35306

@postamar postamar requested a review from a team February 24, 2024 17:03
@postamar postamar enabled auto-merge (squash) February 24, 2024 17:03
Copy link

vercel bot commented Feb 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2024 6:47pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Feb 24, 2024
@erohmensing
Copy link
Contributor

I updated the README and ran build. The quotes diff on the schema is a bit concerning, but I ran the formatter and it didn't seem to care 🤔

Comment on lines +68 to +69
cd airbyte-cdk/python
./gradlew build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:airbyte-cdk:python:build fails, so this is the new normal

@postamar postamar merged commit fdfd048 into master Feb 27, 2024
28 checks passed
@postamar postamar deleted the postamar/fix-generate-to-assemble-dependency-in-python-cdk-build branch February 27, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants