Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

java CDK, source-postgres: speed up tests involving debezium #31924

Merged
merged 10 commits into from
Oct 30, 2023
Merged

java CDK, source-postgres: speed up tests involving debezium #31924

merged 10 commits into from
Oct 30, 2023

Conversation

postamar
Copy link
Contributor

@postamar postamar commented Oct 27, 2023 •
edited
Loading

This PR includes three meaningful, distinct changes which each improve test execution latency when relying on the Debezium engine. These changes aim to have limited impact in a production setting.

Fixes #31828.

@postamar postamar requested a review from a team as a code owner October 27, 2023 15:29
@vercel
Copy link

vercel bot commented Oct 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 2:48pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues CDK Connector Development Kit connectors/source/postgres labels Oct 27, 2023
@github-actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@postamar postamar force-pushed the postamar/dbz-postgres-test-speedup branch from 319cc16 to 691b3a0 Compare October 27, 2023 15:31
@octavia-squidington-iv octavia-squidington-iv requested a review from a team October 27, 2023 15:31
@postamar postamar requested review from subodh1810 and removed request for a team October 27, 2023 15:35
@octavia-squidington-iv octavia-squidington-iv requested a review from a team October 27, 2023 16:12
rodireich
rodireich reviewed Oct 27, 2023
View reviewed changes
airbyte-integrations/connectors/source-postgres/build.gradle
@@ -9,7 +9,7 @@ plugins {
airbyteJavaConnector {
cdkVersionRequired = '0.1.13'
features = ['db-sources']
useLocalCdk = false
useLocalCdk = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reminder to turn back to false prior to merging

@postamar postamar removed the request for review from a team October 27, 2023 16:42
@octavia-squidington-iv octavia-squidington-iv requested a review from a team October 27, 2023 16:42
@postamar postamar requested a review from rodireich October 27, 2023 16:43
@postamar
Copy link
Contributor Author

merging master to get around annoying dockerhub limitations

@postamar
Copy link
Contributor Author

Approve-and-merge failed with client_payload is too large., merging manually instead.

@postamar postamar merged commit 9307d8b into master Oct 30, 2023
@postamar postamar deleted the postamar/dbz-postgres-test-speedup branch October 30, 2023 18:58
@postamar postamar restored the postamar/dbz-postgres-test-speedup branch October 30, 2023 18:58
@postamar
Copy link
Contributor Author

I merged the wrong PR 😬
reverting.

postamar pushed a commit that referenced this pull request Oct 30, 2023
Revert "java CDK, source-postgres: speed up tests involving debezium (#…
0f2ad96 
…31924)"

This reverts commit 9307d8b.
@postamar postamar mentioned this pull request Oct 30, 2023
Merged
@postamar
Copy link
Contributor Author

Merge reverted with #31975

PR reopened as #31960

Sorry for the noise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subodh1810 subodh1810 Awaiting requested review from subodh1810

@rodireich rodireich Awaiting requested review from rodireich

Assignees
No one assigned
Labels
area/connectors Connector related issues CDK Connector Development Kit connectors/source/postgres
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

java CDK: make DebeziumRecordIterator less time-sensitive in tests
3 participants
@postamar @rodireich @octavia-squidington-iii