add --init to docker run #2571
Merged
add --init to docker run #2571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing the final round of manual testing on the cancellation API on real sources (not just loops I was setting up), I noticed that while the
docker runprocess that was running onairbyte-schedulerwould always get killed, in some cases for sources the underlying container would not get killed.Here's discussion on this:
moby/moby#2838 (comment)
This change fixes the behavior and means that
process.destroy()will actually destroy the underlying container. (Btw, this also means timeouts weren't actually working properly before.)I'm putting this in a separate PR since it seems like a pretty wide-reaching but low-impact change.