Postgres Source: fixed bug with non readable double-quoted values within a database name or column name #23383

VitaliiMaltsev · 2023-02-23T13:16:42Z

What

Fix for 20456

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

…hin a database name or column name

VitaliiMaltsev · 2023-02-23T13:17:10Z

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/4253000540
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/4253000540
No Python unittests run

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 64 passed, 3 skipped in 113.37s (0:01:53) ===================

github-actions · 2023-02-23T13:19:26Z

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

Run integration tests
Bump connector or module version
Add changelog
Publish the new version

✅ Sources (25)

Connector	Version	Changelog	Publish
`source-alloydb`	`1.0.48`	✅	✅
`source-alloydb-strict-encrypt`	`1.0.48`	🔵 (ignored)	🔵 (ignored)
`source-bigquery`	`0.2.3`	✅	✅
`source-clickhouse`	`0.1.15`	✅	✅
`source-clickhouse-strict-encrypt`	`0.1.15`	🔵 (ignored)	🔵 (ignored)
`source-cockroachdb`	`0.1.19`	✅	✅
`source-cockroachdb-strict-encrypt`	`0.1.19`	🔵 (ignored)	🔵 (ignored)
`source-db2`	`0.1.17`	✅	✅
`source-db2-strict-encrypt`	`0.1.17`	🔵 (ignored)	🔵 (ignored)
`source-dynamodb`	`0.1.1`	✅	✅
`source-jdbc`	`0.3.5`	🔵 (ignored)	🔵 (ignored)
`source-mongodb-strict-encrypt`	`0.1.19`	🔵 (ignored)	🔵 (ignored)
`source-mongodb-v2`	`0.1.19`	✅	✅
`source-mssql`	`0.4.29`	✅	✅
`source-mssql-strict-encrypt`	`0.4.29`	🔵 (ignored)	🔵 (ignored)
`source-mysql`	`1.0.21`	✅	✅
`source-mysql-strict-encrypt`	`1.0.21`	🔵 (ignored)	🔵 (ignored)
`source-oracle`	`0.3.22`	✅	✅
`source-oracle-strict-encrypt`	`0.3.22`	🔵 (ignored)	🔵 (ignored)
`source-postgres`	`1.0.49`	✅	✅
`source-postgres-strict-encrypt`	`1.0.49`	🔵 (ignored)	🔵 (ignored)
`source-redshift`	`0.3.16`	✅	✅
`source-scaffold-java-jdbc`	`0.1.0`	🔵 (ignored)	🔵 (ignored)
`source-snowflake`	`0.1.30`	✅	✅
`source-tidb`	`0.2.2`	✅	✅

See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)

Connector	Version	Changelog	Publish

See "Actionable Items" below for how to resolve warnings and errors.

✅ Other Modules (0)

Actionable Items

(click to expand)

Category	Status	Actionable Item
Version	❌ mismatch	The version of the connector is different from its normal variant. Please bump the version of the connector.
	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
Changelog	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
	❌ changelog missing	There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish	⚠ not in seed	The connector is not in the seed file (e.g. `source_definitions.yaml`), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
	❌ diff seed version	The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the `/publish` command to publish the latest version.

…tgres-escape-quotes

VitaliiMaltsev · 2023-02-27T10:14:46Z

/publish connector=connectors/source-postgres

🕑 Publishing the following connectors:
connectors/source-postgres
https://github.com/airbytehq/airbyte/actions/runs/4281261729

Connector	Did it publish?	Were definitions generated?
connectors/source-postgres	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

VitaliiMaltsev · 2023-02-27T11:18:32Z

/publish connector=connectors/source-postgres-strict-encrypt

🕑 Publishing the following connectors:
connectors/source-postgres-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/4281800305

Connector	Did it publish?	Were definitions generated?
connectors/source-postgres-strict-encrypt	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…tgres-escape-quotes

VitaliiMaltsev · 2023-02-27T11:30:45Z

/publish connector=connectors/source-alloydb

🕑 Publishing the following connectors:
connectors/source-alloydb
https://github.com/airbytehq/airbyte/actions/runs/4281897396

Connector	Did it publish?	Were definitions generated?
connectors/source-alloydb	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

VitaliiMaltsev · 2023-02-27T11:31:01Z

/publish connector=connectors/source-alloydb-strict-encrypt

🕑 Publishing the following connectors:
connectors/source-alloydb-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/4281899775

Connector	Did it publish?	Were definitions generated?
connectors/source-alloydb-strict-encrypt	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…hin a database name or column name (airbytehq#23383) * Postgres Source: fixed bug with non readable double-quoted values within a database name or column name * bump version * auto-bump connector version * bump AlloyDB version * auto-bump connector version --------- Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

Postgres Source: fixed bug with non readable double-quoted values wit…

0a2c861

…hin a database name or column name

octavia-squidington-iii added area/connectors Connector related issues connectors/source/postgres connectors/source/relational-db labels Feb 23, 2023

VitaliiMaltsev marked this pull request as ready for review February 23, 2023 14:32

VitaliiMaltsev requested a review from a team as a code owner February 23, 2023 14:32

VitaliiMaltsev and others added 7 commits February 23, 2023 16:32

Merge branch 'master' into postgres-escape-quotes

f3e8bec

Merge branch 'master' into postgres-escape-quotes

9966348

Merge branch 'master' into postgres-escape-quotes

2f11802

Merge branch 'master' into postgres-escape-quotes

775347b

Merge branch 'master' into postgres-escape-quotes

2241997

Merge remote-tracking branch 'origin/postgres-escape-quotes' into pos…

ec02776

…tgres-escape-quotes

bump version

128e2c8

octavia-squidington-iii added area/documentation Improvements or additions to documentation connectors/source/postgres-strict-encrypt labels Feb 24, 2023

VitaliiMaltsev mentioned this pull request Feb 24, 2023

Postgres Source: fixed bug with non readable double-quoted values within a database name or column name #22811

Closed

37 tasks

sashaNeshcheret approved these changes Feb 24, 2023

View reviewed changes

VitaliiMaltsev added 2 commits February 27, 2023 12:00

Merge branch 'master' into postgres-escape-quotes

e527f3a

Merge branch 'master' into postgres-escape-quotes

d2651be

auto-bump connector version

4882275

VitaliiMaltsev added 2 commits February 27, 2023 13:29

bump AlloyDB version

75f84d6

Merge remote-tracking branch 'origin/postgres-escape-quotes' into pos…

0d78f5d

…tgres-escape-quotes

octavia-squidington-iii added connectors/source/alloydb connectors/source/alloydb-strict-encrypt labels Feb 27, 2023

auto-bump connector version

fbb92cd

VitaliiMaltsev merged commit 0f5c0e9 into master Feb 27, 2023

VitaliiMaltsev deleted the postgres-escape-quotes branch February 27, 2023 12:36

VitaliiMaltsev linked an issue Feb 28, 2023 that may be closed by this pull request

A double-quote within a database name causes the psql source to throw an exception #20456

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Postgres Source: fixed bug with non readable double-quoted values within a database name or column name #23383

Postgres Source: fixed bug with non readable double-quoted values within a database name or column name #23383

VitaliiMaltsev commented Feb 23, 2023 •

edited

Loading

VitaliiMaltsev commented Feb 23, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Feb 23, 2023 •

edited

Loading

✅ Sources (25)

✅ Destinations (0)

✅ Other Modules (0)

Actionable Items

VitaliiMaltsev commented Feb 27, 2023 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Feb 27, 2023 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Feb 27, 2023 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Feb 27, 2023 •

edited by github-actions bot

Loading

Postgres Source: fixed bug with non readable double-quoted values within a database name or column name #23383

Postgres Source: fixed bug with non readable double-quoted values within a database name or column name #23383

Conversation

VitaliiMaltsev commented Feb 23, 2023 • edited Loading

What

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

VitaliiMaltsev commented Feb 23, 2023 • edited by github-actions bot Loading

Build Passed

github-actions bot commented Feb 23, 2023 • edited Loading

Affected Connector Report

✅ Sources (25)

✅ Destinations (0)

✅ Other Modules (0)

Actionable Items

VitaliiMaltsev commented Feb 27, 2023 • edited by github-actions bot Loading

VitaliiMaltsev commented Feb 27, 2023 • edited by github-actions bot Loading

VitaliiMaltsev commented Feb 27, 2023 • edited by github-actions bot Loading

VitaliiMaltsev commented Feb 27, 2023 • edited by github-actions bot Loading

VitaliiMaltsev commented Feb 23, 2023 •

edited

Loading

VitaliiMaltsev commented Feb 23, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Feb 23, 2023 •

edited

Loading

VitaliiMaltsev commented Feb 27, 2023 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Feb 27, 2023 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Feb 27, 2023 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Feb 27, 2023 •

edited by github-actions bot

Loading