Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Amplitude: handle null values and ampty strings in datetimefields #21957

Merged
merged 4 commits into from
Jan 27, 2023
Merged

Source Amplitude: handle null values and ampty strings in datetimefields #21957

merged 4 commits into from
Jan 27, 2023

Conversation

davydov-d
Copy link
Collaborator

What

https://github.com/airbytehq/oncall/issues/1347

How

If a datetime field contains a null value or empty string - do not try to convert it, just leave it as is

@octavia-squidington-iv octavia-squidington-iv added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/amplitude labels Jan 27, 2023
@davydov-d
Copy link
Collaborator Author

davydov-d commented Jan 27, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-amplitude

🕑 connectors/source-amplitude https://github.com/airbytehq/airbyte/actions/runs/4022778487
❌ connectors/source-amplitude https://github.com/airbytehq/airbyte/actions/runs/4022778487
🐛

@davydov-d
Copy link
Collaborator Author

davydov-d commented Jan 27, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-amplitude

🕑 connectors/source-amplitude https://github.com/airbytehq/airbyte/actions/runs/4023058770

@davydov-d
Copy link
Collaborator Author

I'm gonna publish this change without running tests because our previous test account has been deactivated in GSM (probably due to real/live data in it) and our new account produces an error during a test run.
I have run the tests locally using previous creds:
image

@davydov-d
Copy link
Collaborator Author

davydov-d commented Jan 27, 2023 •
edited by github-actions bot
Loading

/publish connector=connectors/source-amplitude run-tests=false

🕑 Publishing the following connectors:
connectors/source-amplitude
https://github.com/airbytehq/airbyte/actions/runs/4026044850


Connector Did it publish? Were definitions generated?
connectors/source-amplitude ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 27, 2023 16:11 — with GitHub Actions Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 27, 2023 16:11 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 24% ❌

@davydov-d davydov-d merged commit b1a0a4d into master Jan 27, 2023
@davydov-d davydov-d deleted the ddavydov/#1347-source-amplitude-handle-null-values-in-datetime-fields branch January 27, 2023 16:48
This was referenced Jan 27, 2023
Closed
Merged
debanjan97 pushed a commit to rudderlabs/airbyte that referenced this pull request Feb 8, 2023
@davydov-d @octavia-squidington-iii @debanjan97
Source Amplitude: handle null values and ampty strings in datetimefie…
6366e4a 
…lds (airbytehq#21957)

* airbytehq#1347 source Amplitude: handle null values and ampty strings in datetime fields

* airbytehq#1347 source Amplitude: upd changelog

* airbytehq#1347 source amplitude: fix tests

* auto-bump connector version

---------

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
@debanjan97 debanjan97 mentioned this pull request Feb 8, 2023
Merged
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bazarnov bazarnov bazarnov approved these changes

@lazebnyi lazebnyi Awaiting requested review from lazebnyi

@roman-yermilov-gl roman-yermilov-gl Awaiting requested review from roman-yermilov-gl

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/amplitude
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davydov-d @bazarnov @octavia-squidington-iii @octavia-squidington-iv