-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set availabilitystrategy for GA connectors + gitlab with httpstreams explicitly to None
#21888
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ms on this source)
This was referenced Jan 27, 2023
Closing in favor of the separate PRs now that all follow up issues have been created |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
connectors/source/amazon-ads
connectors/source/amplitude
connectors/source/facebook-marketing
connectors/source/freshdesk
connectors/source/github
connectors/source/gitlab
connectors/source/google-analytics-v4
connectors/source/google-search-console
connectors/source/harvest
connectors/source/hubspot
connectors/source/intercom
connectors/source/iterable
connectors/source/klaviyo
connectors/source/linkedin-ads
connectors/source/mailchimp
connectors/source/marketo
connectors/source/mixpanel
connectors/source/notion
connectors/source/paypal-transaction
connectors/source/pinterest
connectors/source/recharge
connectors/source/salesforce
connectors/source/sentry
connectors/source/slack
connectors/source/snapchat-marketing
connectors/source/stripe
connectors/source/surveymonkey
connectors/source/tiktok-marketing
connectors/source/twilio
connectors/source/zendesk-chat
connectors/source/zendesk-support
connectors/source/zendesk-talk
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Now that the HttpAvailabilityStrategy is published in the CDK, we want to turn it on as default for HttpStreams. In order to prevent issues in GA connectors if there is unexpected incompatibility or issues, we want to turn on the HttpAvailability (or a substitute custom AvailabilityStrategy)
How
I found a list of GA python connectors by scripting the following:
airbyte-integrations/connectors
foldersetup.py
files somewhere in their foldergenerally-available
For each of those, if the GA python source was using
HttpStream
s and was anAbstractSource
, I set the AvailabilityStrategy explicitly toNone
by doing the following:availability_strategy
to the base stream class for that source's streams, set toNone
There are 31 of these, + gitlab = 32, so there should be 96 changed files.
Note that this doesn't change how the connector will behave - the default for all AvailabilityStrategies at the moment is
None
. This is being done in preparation for #21924, where the default will be set toHttpAvailabilityStrategy
, which will switch it on for all alpha/beta connectors minus gitlab.Pre-merge
Follow up