Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connector Ops CI: introduce QA engine #21709

Merged
merged 3 commits into from
Jan 24, 2023
Merged

Connector Ops CI: introduce QA engine #21709

merged 3 commits into from
Jan 24, 2023

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Jan 23, 2023 •
edited
Loading

What

Closes #21711

I want to bootstrap the QA engine with this PR.
It introduces a new GitHub action workflow, which is triggered daily and write the QA engine results to GCS.
It's not currently computing anything at the moment.
We're just defining:

  • The inputs: Oss + Cloud catalog, adoption metrics
  • The output: a JSON report file we host to GCS with an enforced schema.

How

  1. Create a qa-engine package in the ci_connectors_ops package
  2. Define inputs, models, main modules
  3. Expose the entrypoint + install requirements in setup.py
  4. Call the entrypoint from a new GitHub action (Run QA Engine) scheduled to run daily, at the same time as the existing build report.
  5. Write basic tests

@alafanechere alafanechere temporarily deployed to more-secrets January 23, 2023 15:40 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets January 23, 2023 15:41 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets January 23, 2023 15:45 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets January 23, 2023 15:45 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2023 •
edited
Loading

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 26.7% 🍏

@alafanechere alafanechere force-pushed the augustin/introduce-qa-engine branch from 816197d to 8b0b886 Compare January 23, 2023 16:11
alafanechere
alafanechere commented Jan 23, 2023
View reviewed changes
.github/workflows/run-qa-engine.yml
@@ -0,0 +1,30 @@
name: Run QA Engine
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not test this workflow as it needs to be on the main branch to be manually triggered.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be helpful for you: https://github.com/airbytehq/github-workflow-test-repo-base (see readme, topher directed me toward it)

@alafanechere alafanechere marked this pull request as ready for review January 23, 2023 16:11
@alafanechere alafanechere requested a review from a team January 23, 2023 16:12
@alafanechere alafanechere temporarily deployed to more-secrets January 23, 2023 16:13 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets January 23, 2023 16:13 — with GitHub Actions Inactive
@alafanechere alafanechere mentioned this pull request Jan 23, 2023
Closed
@alafanechere alafanechere temporarily deployed to more-secrets January 23, 2023 18:09 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets January 23, 2023 18:09 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2023 •
edited
Loading

Platform Test Results

   233 files  ±0     233 suites  ±0   27m 58s ⏱️ + 1m 11s
1 610 tests ±0  1 599 ✔️ ±0  11 💤 ±0  0 ❌ ±0 
1 630 runs  ±0  1 619 ✔️ ±0  11 💤 ±0  0 ❌ ±0 

Results for commit 2462e9d. ± Comparison against base commit 3b1864f.

♻️ This comment has been updated with latest results.

@alafanechere alafanechere temporarily deployed to more-secrets January 23, 2023 22:03 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets January 23, 2023 22:03 — with GitHub Actions Inactive
evantahler
evantahler approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a good start!

.github/workflows/run-qa-engine.yml
Comment on lines +20 to +22
with:
service_account_key: ${{ secrets.PROD_SPEC_CACHE_SA_KEY }}
export_default_credentials: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a new secret?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, it's the one used by the deploy-oss-catalog.yml workflow, we use it to write to GCS.

@alafanechere alafanechere merged commit 4770a8f into master Jan 24, 2023
@alafanechere alafanechere deleted the augustin/introduce-qa-engine branch January 24, 2023 08:35
@github-actions github-actions bot mentioned this pull request Jan 24, 2023
Closed
This was referenced Jan 27, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erohmensing erohmensing erohmensing left review comments

@evantahler evantahler evantahler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connector Ops CI: bootstrap QA engine
3 participants
@alafanechere @evantahler @erohmensing