Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove source and destination definition calls that were used only to get the icon in Streams Field Table #21608

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Remove source and destination definition calls that were used only to get the icon in Streams Field Table #21608

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions ...ts/connection/CatalogTree/next/StreamDetailsPanel/StreamFieldsTable/StreamFieldsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ import { NextTable } from "components/ui/NextTable";
import { SyncSchemaField, SyncSchemaFieldObject } from "core/domain/catalog";
import { AirbyteStreamConfiguration } from "core/request/AirbyteClient";
import { useConnectionFormService } from "hooks/services/ConnectionForm/ConnectionFormService";
import { useDestinationDefinition } from "services/connector/DestinationDefinitionService";
import { useSourceDefinition } from "services/connector/SourceDefinitionService";
import { equal } from "utils/objects";
import { getDataType } from "utils/useTranslateDataType";

Expand Down Expand Up @@ -59,8 +57,6 @@ export const StreamFieldsTable: React.FC<StreamFieldsTableProps> = ({
const {
connection: { source, destination },
} = useConnectionFormService();
const sourceDefinition = useSourceDefinition(source.sourceDefinitionId);
const destinationDefinition = useDestinationDefinition(destination.destinationDefinitionId);

// prepare data for table
const tableData: TableStream[] = useMemo(
Expand Down Expand Up @@ -163,7 +159,7 @@ export const StreamFieldsTable: React.FC<StreamFieldsTableProps> = ({
() => [
columnHelper.group({
id: "source",
header: () => <ConnectorHeaderGroupIcon type="source" icon={sourceDefinition.icon} />,
header: () => <ConnectorHeaderGroupIcon type="source" icon={source.icon} />,
columns: sourceColumns,
meta: {
thClassName: styles.headerGroupCell,
Expand All @@ -188,15 +184,15 @@ export const StreamFieldsTable: React.FC<StreamFieldsTableProps> = ({
}),
columnHelper.group({
id: "destination",
header: () => <ConnectorHeaderGroupIcon type="destination" icon={destinationDefinition.icon} />,
header: () => <ConnectorHeaderGroupIcon type="destination" icon={destination.icon} />,
columns: destinationColumns,
meta: {
thClassName: styles.headerGroupCell,
tdClassName: styles.bodyCell,
},
}),
],
[columnHelper, destinationColumns, destinationDefinition.icon, sourceColumns, sourceDefinition.icon]
[columnHelper, destination.icon, destinationColumns, source.icon, sourceColumns]
);

return <NextTable<TableStream> columns={columns} data={tableData} className={styles.customTableStyle} />;
Expand Down