Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Gitlab: fetch groups along with subgroups #20384

Merged
merged 6 commits into from
Dec 13, 2022

Conversation

davydov-d
Copy link
Collaborator

@davydov-d davydov-d commented Dec 12, 2022

What

#11248

How

Refactor _get_group_list to be a Stream class and use these APIs under the hood:

@octavia-squidington-iv octavia-squidington-iv added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/gitlab labels Dec 12, 2022
@davydov-d
Copy link
Collaborator Author

davydov-d commented Dec 12, 2022

/test connector=connectors/source-gitlab

🕑 connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/3679189912
❌ connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/3679189912
🐛 https://gradle.com/s/fugeypzyck6ea

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contai...
FAILED test_core.py::TestBasicRead::test_read[inputs1] - docker.errors.Contai...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
============= 3 failed, 30 passed, 31 warnings in 87.65s (0:01:27) =============

@davydov-d
Copy link
Collaborator Author

davydov-d commented Dec 13, 2022

/test connector=connectors/source-gitlab

🕑 connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/3683706222
❌ connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/3683706222
🐛 https://gradle.com/s/zytfjp3mc4uq4

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs1] - AssertionError: All ...
============ 1 failed, 32 passed, 31 warnings in 251.19s (0:04:11) =============

@davydov-d
Copy link
Collaborator Author

davydov-d commented Dec 13, 2022

/publish connector=connectors/source-gitlab

🕑 Publishing the following connectors:
connectors/source-gitlab
https://github.com/airbytehq/airbyte/actions/runs/3683987019


Connector Did it publish? Were definitions generated?
connectors/source-gitlab

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@davydov-d
Copy link
Collaborator Author

davydov-d commented Dec 13, 2022

/publish connector=connectors/source-gitlab

🕑 Publishing the following connectors:
connectors/source-gitlab
https://github.com/airbytehq/airbyte/actions/runs/3684352205


Connector Did it publish? Were definitions generated?
connectors/source-gitlab

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets December 13, 2022 10:34 — with GitHub Actions Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets December 13, 2022 10:35 — with GitHub Actions Inactive
@davydov-d davydov-d merged commit 2ee250e into master Dec 13, 2022
@davydov-d davydov-d deleted the ddavydov/#11248-source-gitlab-fetch-subgroups branch December 13, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/gitlab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants