Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix passing workspace ID to definition lists #19503

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Fix passing workspace ID to definition lists #19503

merged 1 commit into from
Nov 16, 2022

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Nov 16, 2022

What

Fix broken master build, due to #19366 and #19221 being merged too close to each other and conflicting with each other.

@timroes timroes requested a review from a team as a code owner November 16, 2022 20:48
@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Nov 16, 2022
krishnaglick
krishnaglick approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@krishnaglick krishnaglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, did not test locally, build should catch any errors

@timroes timroes merged commit 4b7f677 into master Nov 16, 2022
@timroes timroes deleted the tim/fix-broken-build branch November 16, 2022 21:38
@github-actions github-actions bot mentioned this pull request Nov 17, 2022
Merged
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Nov 18, 2022
Merged
akashkulk pushed a commit that referenced this pull request Dec 2, 2022
@akashkulk
Fix passing workspace ID to definition lists (#19503)
ff5be39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishnaglick krishnaglick krishnaglick approved these changes

@josephkmh josephkmh josephkmh approved these changes

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timroes @krishnaglick @josephkmh @octavia-squidington-iv