🪟 🎉 Show an error when OAuth credentials are missing #19466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
added
team/extensibility
area/frontend
josephkmh
approved these changes
Nov 16, 2022
| notificationService.registerNotification({ | ||
| id: "oauthConnector.credentialsMissing", | ||
| // Since it's dev only we don't need i18n on this string | ||
| title: "OAuth is not enabled for this connector on this environment.", |
There was a problem hiding this comment.
Just out of curiosity - do we have any OAuth connectors enabled in dev mode? From this message it sounds like some are enabled.
There was a problem hiding this comment.
Yes, you can find the (internal) documentation to what we have enabled on frontend-dev here: https://www.notion.so/Testing-OAuth-Locally-fea17aeb14c74cacb5f3ed856daae753
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #17143
Show a toast notification in case the
get_consent_urlreturns a 404, which means that the database has no OAuth credentials for this connector. This is a problem that needs to be solved by the connector team. Also track a Datadog error for this, that we can build alerting on top of.We show a different error when running in dev mode (
npm start), that gives more hints towards that it's a more normal situation there and we just never have enabled this OAuth connector in that given environment.Best to be reviewed with "Ignore whitespaces".