🪟 🐛 Remove reinitialization of AnalyticsService #19304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
added
team/compose
area/frontend
timroes
commented
Nov 10, 2022
| @@ -29,11 +29,11 @@ export const useIntercom = (): IntercomContextValues => { | |||
| useEffect(() => { | |||
| intercomContextValues.update({ | |||
| customAttributes: { | |||
| workspace_id: analyticsContext.workspace_id, | |||
There was a problem hiding this comment.
ℹ️ This likely never worked, since there was no workspace_id on that analytics context, but since it was also not typed it was never caught. Switched this to use the actual correct hook.
josephkmh
approved these changes
Nov 11, 2022
akashkulk
pushed a commit
that referenced
this pull request
Dec 2, 2022
* Remvoe reinitialization of AnalyticsService * Change to ref * Make useCurrentWorkspaceId work globally * Fix workspace id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This cleans up the AnalyticsService to no longer reinitialize every time someone changes the context parameters on it.
We've noticed that in Segment a lot of the User.Create events are coming with
experimentsand - while not being able to reproduce fully - I suspect the issue here was, that as soon as we create a user/login we change the context, which itself will cause a newAnalyticsServiceto be recreated, while though some components that haven't rerendered might still send their events to the old instance with the old context.Either way not recreating this class on every context change sounds like the better approach, so we should give this a try if it fixes our login problem.
I've validated that intercom still gets the correct workspace_id send as a property, as well as segment events still getting the right properties and they are changing correctly when e.g. changing workspace.