Enable the Connector Builder server in the platform #19269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to see if it fixes CI" This reverts commit 40b5ae0.
|
@lmossman doesn't it have the |
lmossman
changed the title
…container (#19495) * Revert "try adding buildDockerImage task" This reverts commit 2102009. * Revert "try adding connector builder server to 'generate-docker' task to see if it fixes CI" This reverts commit 40b5ae0. * missing file * build airbyte-connector-builder-server image * Add . * comment * build connector builder server as part of octavia_cli * build connector builder too * patch * missing file * comment * comment * run unit tests in a container * Run integration tests * run * move to platform build * format * rootdir * get the path from the project * Update * pyproject * delete a bunch of code * parameterize * run tests * update * rename * comment * reset * uncomment * dont format * run everything except isort * delete dead code * Revert "delete dead code" This reverts commit b11df71. * comment * Update module * reset to master * mount in home * commit formatted files * try running format * Better comment * reset * Revert "reset" This reverts commit 20808f8. * Update buildSrc/src/main/groovy/airbyte-python-docker.gradle Co-authored-by: Sherif A. Nada <snadalive@gmail.com> * comment * Add everything except build and hidden directories * symlink * Update airbyte-connector-builder-server/run_format.sh Co-authored-by: Sherif A. Nada <snadalive@gmail.com> * Update airbyte-connector-builder-server/run_tests.sh Co-authored-by: Sherif A. Nada <snadalive@gmail.com> Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
lmossman
changed the title
girarda
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR enables the connector builder in the platform's docker-compose, and removes the mock data in the frontend so that the connector builder UI is actually making calls to the backend connector-builder-server.