Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add attempt number to trace tags #19241

Merged
merged 4 commits into from
Nov 9, 2022
Merged

Add attempt number to trace tags #19241

merged 4 commits into from
Nov 9, 2022

Conversation

jdpgrailsdev
Copy link
Contributor

@jdpgrailsdev jdpgrailsdev commented Nov 9, 2022 •
edited
Loading

What

  • Improve visibility into Temporal retry attempts

How

  • Add attempt number (where available) to APM trace
  • Correctly suppress superfluous error messages in traces

Recommended reading order

  1. ApmTraceConstants.java
  2. *ActivityImpl.java
  3. *WorkflowImpl.java

Tests

  • All tests pass
  • Project builds successfully

@github-actions github-actions bot added area/platform issues related to the platform area/worker Related to worker labels Nov 9, 2022
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets November 9, 2022 17:38 Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets November 9, 2022 19:57 Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets November 9, 2022 20:01 Inactive
@jdpgrailsdev
Copy link
Contributor Author

Related to https://github.com/airbytehq/airbyte-internal-issues/issues/1105.

@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets November 9, 2022 20:45 Inactive
gosusnp
gosusnp approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@gosusnp gosusnp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jdpgrailsdev jdpgrailsdev merged commit 0e036db into master Nov 9, 2022
@jdpgrailsdev jdpgrailsdev deleted the jonathan/record-attempt-number branch November 9, 2022 21:27
@github-actions github-actions bot mentioned this pull request Nov 15, 2022
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Nov 18, 2022
Merged
akashkulk pushed a commit that referenced this pull request Dec 2, 2022
@jdpgrailsdev @akashkulk
Add attempt number to trace tags (#19241)
d7e5984 
* Add attempt number to trace tags

* Use correct tag key for error suppression
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gosusnp gosusnp gosusnp approved these changes

@benmoriceau benmoriceau benmoriceau approved these changes

@colesnodgrass colesnodgrass Awaiting requested review from colesnodgrass

@alovew alovew Awaiting requested review from alovew

Assignees
No one assigned
Labels
area/platform issues related to the platform area/worker Related to worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdpgrailsdev @gosusnp @benmoriceau