Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows user to specify grant_type in OAuthAuthenticator #19139

Merged

Conversation

jj-nilbodee
Copy link
Contributor

What

I'm trying to solve the issues where some of the connectors cannot migrate to use low-code CDK because it's using grant_type=client_credentials with OAuthAuthenticator

How

Allow users to be able to specify grant_type for OAuthAuthenticator while preserve the old behaviour by using a default value as refresh_token

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@jj-nilbodee jj-nilbodee requested a review from a team November 8, 2022 20:23
@github-actions github-actions bot added area/documentation Improvements or additions to documentation CDK Connector Development Kit labels Nov 8, 2022
@sherifnada sherifnada self-requested a review November 8, 2022 22:14
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! @jhajajaas could you add a test case in test_oauth.py and test_requests_native_auth.py to validate the grant_type is set properly?

Also, mind incrementing the version in setup.py with a minor version and adding a line in the changelog?

@sherifnada sherifnada merged commit 33227f5 into airbytehq:master Nov 11, 2022
@jj-nilbodee jj-nilbodee deleted the allow-oauth-to-specify-grant-type branch November 11, 2022 14:17
sherifnada added a commit that referenced this pull request Nov 11, 2022
akashkulk pushed a commit that referenced this pull request Dec 2, 2022
Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
akashkulk pushed a commit that referenced this pull request Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation CDK Connector Development Kit community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants