-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows user to specify grant_type in OAuthAuthenticator #19139
Merged
sherifnada
merged 7 commits into
airbytehq:master
from
jj-nilbodee:allow-oauth-to-specify-grant-type
Nov 11, 2022
Merged
Allows user to specify grant_type in OAuthAuthenticator #19139
sherifnada
merged 7 commits into
airbytehq:master
from
jj-nilbodee:allow-oauth-to-specify-grant-type
Nov 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherifnada
suggested changes
Nov 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! @jhajajaas could you add a test case in test_oauth.py
and test_requests_native_auth.py
to validate the grant_type is set properly?
Also, mind incrementing the version in setup.py
with a minor version and adding a line in the changelog?
sherifnada
approved these changes
Nov 11, 2022
sherifnada
added a commit
that referenced
this pull request
Nov 11, 2022
akashkulk
pushed a commit
that referenced
this pull request
Dec 2, 2022
Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
akashkulk
pushed a commit
that referenced
this pull request
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/documentation
Improvements or additions to documentation
CDK
Connector Development Kit
community
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I'm trying to solve the issues where some of the connectors cannot migrate to use low-code CDK because it's using
grant_type=client_credentials
with OAuthAuthenticatorHow
Allow users to be able to specify
grant_type
for OAuthAuthenticator while preserve the old behaviour by using a default value asrefresh_token
Recommended reading order
x.java
y.python
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.