Generate cloud api client from airbyte-cloud if present #19091
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
As of #19026, we've got cloud tooling affordances relying on
airbyte
andairbyte-cloud
being sibling directories in a dev's filesystem. This opens up the possibility of generating API client code for cloud endpoints (defined inairbyte-cloud/cloud-api/src/main/openapi/config.yaml
); to date, cloud API client code has been written by hand, leading to the possibility of bugs from server/client code drift.How
fs.existsSync
to check for the airbyte-cloud repo'sopenapi/config.yaml
; if it exists, provide orval config to generate client code.What might not work?
AirbyteCloudApiClient.ts
break the build even if it's not in the module graph for the OSS react app?remaining TODOs:
airbyte
away fromairbyte-cloud
and runnpm start
to generate api clients and build appimport
s fail