Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source snowflake: emit cursor count in state #18955

Closed
wants to merge 2 commits into from

Conversation

tuliren
Copy link
Contributor

@tuliren tuliren commented Nov 4, 2022

What

🚨 User Impact 🚨

@tuliren tuliren requested a review from a team as a code owner November 4, 2022 08:12
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Nov 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector version
  • Add changelog
  • Publish the new version

❌ Sources (1)

Connector Version Changelog Publish
source-snowflake 0.1.25
(diff seed version)
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)

Connector Version Changelog Publish
  • See "Actionable Items" below for how to resolve warnings and errors.

Actionable Items

(click to expand)

Category Status Actionable Item
Version
mismatch
The version of the connector is different from its normal variant. Please bump the version of the connector.

doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog
doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.

changelog missing
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish
not in seed
The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.

diff seed version
The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version.

@tuliren tuliren mentioned this pull request Nov 4, 2022
28 tasks
@tuliren
Copy link
Contributor Author

tuliren commented Nov 4, 2022

Currently, Snowflake integration test fails:

https://github.com/airbytehq/airbyte/actions/runs/3392053935/jobs/5637830648

SnowflakeSourceAuthAcceptanceTest > testDiscover() FAILED
    java.lang.RuntimeException: Failed to obtain accessToken using refresh token. { "data":null,"error":"invalid_grant","code":null,"message":"The provided grant or refresh token is invalid.","success":false,"headers":null }

@tuliren
Copy link
Contributor Author

tuliren commented Nov 5, 2022

/test connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3400578603
❌ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3400578603
🐛 https://gradle.com/s/ncef3ipps3ud6

Build Failed

Test summary info:

Could not find result summary

@tuliren
Copy link
Contributor Author

tuliren commented Nov 13, 2022

The new version for snowflake has been in another PR.

@tuliren tuliren closed this Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/snowflake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants