Low-code CDK: safe get response.json #18931

davydov-d · 2022-11-03T18:55:48Z

What

Prevent low-code CDK from throwing a JSONDecodeError

How

try-catch this error when accessing request.json() and return an empty dict if it's raised

girarda

lgtm thank you for fixing!

davydov-d · 2022-11-04T08:03:19Z

/publish-cdk dry-run=true

❌ https://github.com/airbytehq/airbyte/actions/runs/3392162704

davydov-d · 2022-11-04T08:27:12Z

/publish-cdk dry-run=true

🕑 https://github.com/airbytehq/airbyte/actions/runs/3392289017
✅ https://github.com/airbytehq/airbyte/actions/runs/3392289017

davydov-d · 2022-11-04T08:35:57Z

/publish-cdk dry-run=true

🕑 https://github.com/airbytehq/airbyte/actions/runs/3392336219
❌ https://github.com/airbytehq/airbyte/actions/runs/3392336219

davydov-d · 2022-11-04T08:48:10Z

/publish-cdk dry-run=false

🕑 https://github.com/airbytehq/airbyte/actions/runs/3392403424
✅ https://github.com/airbytehq/airbyte/actions/runs/3392403424

davydov-d · 2022-11-04T08:56:29Z

/test connector=connectors/source-twilio

🕑 connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/3392455059
✅ connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/3392455059
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_twilio/auth.py           8      0   100%
source_twilio/__init__.py       2      0   100%
source_twilio/source.py        28      2    93%
source_twilio/streams.py      275     24    91%
-----------------------------------------------
TOTAL                         313     26    92%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       133      3    98%   87, 93, 230
	 source_acceptance_test/conftest.py                     196     97    51%   35, 41-43, 48, 54, 60, 66, 72-74, 80-95, 100, 105-107, 113-115, 121-122, 127-128, 133, 139, 148-157, 163-168, 232, 238, 244-250, 258-263, 271-284, 289-295, 302-313, 320-336
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              329    106    68%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 377-379, 382, 447-455, 484-485, 491, 494, 530-540, 553-578
	 source_acceptance_test/tests/test_incremental.py       145     20    86%   21-23, 29-31, 36-43, 48-61, 224
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     10    87%   15-16, 24-30, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/config_migration.py        23     23     0%   5-37
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1479    376    75%

Build Passed

Test summary info:

All Passed

davydov-d · 2022-11-04T08:56:37Z

/test connector=connectors/source-iterable

🕑 connectors/source-iterable https://github.com/airbytehq/airbyte/actions/runs/3392456060
✅ connectors/source-iterable https://github.com/airbytehq/airbyte/actions/runs/3392456060
Python tests coverage:

Name                                  Stmts   Miss  Cover
---------------------------------------------------------
source_iterable/__init__.py               2      0   100%
source_iterable/source.py                34      1    97%
source_iterable/slice_generators.py      71      5    93%
source_iterable/streams.py              351     38    89%
---------------------------------------------------------
TOTAL                                   458     44    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       133      3    98%   87, 93, 230
	 source_acceptance_test/conftest.py                     196     97    51%   35, 41-43, 48, 54, 60, 66, 72-74, 80-95, 100, 105-107, 113-115, 121-122, 127-128, 133, 139, 148-157, 163-168, 232, 238, 244-250, 258-263, 271-284, 289-295, 302-313, 320-336
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              329    106    68%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 377-379, 382, 447-455, 484-485, 491, 494, 530-540, 553-578
	 source_acceptance_test/tests/test_incremental.py       145     20    86%   21-23, 29-31, 36-43, 48-61, 224
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     10    87%   15-16, 24-30, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/config_migration.py        23     23     0%   5-37
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1479    376    75%

Build Passed

Test summary info:

All Passed

davydov-d · 2022-11-04T08:56:44Z

/test connector=connectors/source-marketo

🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/3392456830
✅ connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/3392456830
Python tests coverage:

Name                         Stmts   Miss  Cover
------------------------------------------------
source_marketo/__init__.py       2      0   100%
source_marketo/utils.py         33      1    97%
source_marketo/source.py       271     29    89%
------------------------------------------------
TOTAL                          306     30    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       133      3    98%   87, 93, 230
	 source_acceptance_test/conftest.py                     196     97    51%   35, 41-43, 48, 54, 60, 66, 72-74, 80-95, 100, 105-107, 113-115, 121-122, 127-128, 133, 139, 148-157, 163-168, 232, 238, 244-250, 258-263, 271-284, 289-295, 302-313, 320-336
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              329    106    68%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 377-379, 382, 447-455, 484-485, 491, 494, 530-540, 553-578
	 source_acceptance_test/tests/test_incremental.py       145     20    86%   21-23, 29-31, 36-43, 48-61, 224
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     10    87%   15-16, 24-30, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/config_migration.py        23     23     0%   5-37
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1479    376    75%

Build Passed

Test summary info:

All Passed

low-code cdk: safe get response.json

33e7ba8

davydov-d requested review from a team, brianjlai and girarda November 3, 2022 18:55

davydov-d mentioned this pull request Nov 3, 2022

Source Tempo: migrate to lowcode + certify to beta #18936

Merged

girarda approved these changes Nov 4, 2022

View reviewed changes

flake fix

bdea266

github-actions bot added the CDK Connector Development Kit label Nov 4, 2022

Merge branch 'master' into ddavydov/#cdk-safe-get-response-json

fd8eac4

davydov-d merged commit 8145be5 into master Nov 4, 2022

davydov-d deleted the ddavydov/#cdk-safe-get-response-json branch November 4, 2022 09:44

github-actions bot mentioned this pull request Nov 15, 2022

Bump helm chart version reference to 0.40.43 #19453

Closed

octavia-squidington-iii mentioned this pull request Nov 18, 2022

Bump Airbyte version from 0.40.18 to 0.40.19 #19579

Merged

davydov-d mentioned this pull request Dec 22, 2022

Source Google Analytics Data API: prepare connector to сertification #20769

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Low-code CDK: safe get response.json #18931

Low-code CDK: safe get response.json #18931

davydov-d commented Nov 3, 2022

girarda left a comment

davydov-d commented Nov 4, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 4, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 4, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 4, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 4, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 4, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 4, 2022 •

edited by github-actions bot

Loading

Low-code CDK: safe get response.json #18931

Low-code CDK: safe get response.json #18931

Conversation

davydov-d commented Nov 3, 2022

What

How

girarda left a comment

Choose a reason for hiding this comment

davydov-d commented Nov 4, 2022 • edited by github-actions bot Loading

davydov-d commented Nov 4, 2022 • edited by github-actions bot Loading

davydov-d commented Nov 4, 2022 • edited by github-actions bot Loading

davydov-d commented Nov 4, 2022 • edited by github-actions bot Loading

davydov-d commented Nov 4, 2022 • edited by github-actions bot Loading

Build Passed

davydov-d commented Nov 4, 2022 • edited by github-actions bot Loading

Build Passed

davydov-d commented Nov 4, 2022 • edited by github-actions bot Loading

Build Passed

davydov-d commented Nov 4, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 4, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 4, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 4, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 4, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 4, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 4, 2022 •

edited by github-actions bot

Loading