-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Prestashop: Migrate connector from Alpha (Python) to Beta (YAML) #18927
Merged
Merged
Changes from all commits
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
f3ae381
bump 0.2.1
grubberr 337bb50
prestashop.yaml added
grubberr fe34587
all streams added
grubberr b12bf9a
bump 0.3.0
grubberr da45248
Merge branch 'master' into grubberr/18710-source-prestashop
grubberr 8c22b76
data_key added
grubberr 5e4f99c
Merge branch 'master' into grubberr/18710-source-prestashop
grubberr dad71fa
Merge branch 'master' into grubberr/18710-source-prestashop
grubberr 7aa5cfc
moved primary_key to base_stream
grubberr cbe04b4
Merge branch 'master' into grubberr/18710-source-prestashop
grubberr 2bed075
LimitOffsetPaginator added
grubberr 780e3d4
Merge branch 'master' into grubberr/18710-source-prestashop
grubberr 7c965e1
NoSlicer added
grubberr f16a8bd
stream_cursor_field added
grubberr 5cc8e8c
_filter_params added
grubberr 8f83178
abnormal_state.json added
grubberr 06cd8d0
releaseStage alpha -> beta
grubberr d8d08dd
migrated acceptance-test-config.yml
grubberr d0a12f3
Merge branch 'master' into grubberr/18710-source-prestashop
grubberr fa6eb15
presta-shop.md updated
grubberr f67316c
_validate_and_transform added
grubberr 866e92c
expected_records.txt added
grubberr 730a754
spec change order: "access_key", "url"
grubberr 1452bb6
Merge branch 'master' into grubberr/18710-source-prestashop
grubberr 12956a4
Merge branch 'master' into grubberr/18710-source-prestashop
grubberr 8e7bfbe
Prestashop -> PrestaShop
grubberr 58eff96
presta-shop.md updated
grubberr d209d3f
simplify https check
grubberr bad78f5
timeout_seconds: 300 - removed from spec
grubberr 3ffd091
integration_tests/spec.json -> source_prestashop/spec.yaml
grubberr 8f46497
ConfigException added
grubberr 96f8802
revert back timeout_seconds: 300 for spec
grubberr f9ce677
revert back exception -> failed
grubberr 59afc13
Merge branch 'master' into grubberr/18710-source-prestashop
grubberr 6c56fe5
test_limit_offset_paginator added
grubberr fc17ca0
test_no_slicer added
grubberr ace763d
setup.py updated
grubberr 48d37a4
Merge branch 'master' into grubberr/18710-source-prestashop
grubberr 95d031d
documentationUrl updated
grubberr 57c3307
Merge branch 'master' into grubberr/18710-source-prestashop
grubberr d74988e
checkpoint_interval: 500 added
grubberr 78e7f55
move checkpoint_interval to incremental
grubberr 710f537
Merge branch 'master' into grubberr/18710-source-prestashop
grubberr 9896ad8
switch to DatetimeStreamSlicer
grubberr 28fa4d1
step 10y -> 1y
grubberr de84b57
start_date: 2020-07-01 -> 2021-05-25
grubberr c825adf
Merge branch 'master' into grubberr/18710-source-prestashop
grubberr 44c1d1b
start_date title added
grubberr 62208f5
presta-shop.md updated
grubberr 33aaa21
switch to DefaultPaginator
grubberr f5ac515
Merge branch 'master' into grubberr/18710-source-prestashop
grubberr fee0181
use default paginator
grubberr f46b862
integration_tests/catalog.json removed
grubberr e836e61
Merge branch 'master' into grubberr/18710-source-prestashop
grubberr 73f10bd
disable_for_version: 0.1.0 -> 0.2.0
grubberr 0997f4c
revert me
grubberr 20c5045
Revert "revert me"
grubberr e4f4a0f
fix bad symbols
grubberr 6f4431e
expected_records.txt fixed
grubberr cf8ae2b
Merge branch 'master' into grubberr/18710-source-prestashop
grubberr 0392abc
auto-bump connector version
octavia-squidington-iii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 30 additions & 16 deletions
46
airbyte-integrations/connectors/source-prestashop/acceptance-test-config.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,39 @@ | ||
# See [Source Acceptance Tests](https://docs.airbyte.com/connector-development/testing-connectors/source-acceptance-tests-reference) | ||
# for more information about how to configure these tests | ||
connector_image: airbyte/source-prestashop:dev | ||
tests: | ||
acceptance_tests: | ||
spec: | ||
- spec_path: "source_prestashop/spec.json" | ||
# unfortunately timeout plugin takes into account setup code as well (docker setup) | ||
timeout_seconds: 300 | ||
tests: | ||
- spec_path: "source_prestashop/spec.yaml" | ||
# unfortunately timeout plugin takes into account setup code as well (docker setup) | ||
timeout_seconds: 300 | ||
backward_compatibility_tests_config: | ||
disable_for_version: "0.2.0" | ||
connection: | ||
- config_path: "secrets/config.json" | ||
status: "succeed" | ||
- config_path: "integration_tests/invalid_config.json" | ||
status: "failed" | ||
tests: | ||
- config_path: "secrets/config.json" | ||
status: "succeed" | ||
- config_path: "integration_tests/invalid_config.json" | ||
status: "failed" | ||
discovery: | ||
- config_path: "secrets/config.json" | ||
tests: | ||
- config_path: "secrets/config.json" | ||
basic_read: | ||
- config_path: "secrets/config.json" | ||
configured_catalog_path: "integration_tests/configured_catalog.json" | ||
tests: | ||
- config_path: "secrets/config.json" | ||
configured_catalog_path: "integration_tests/configured_catalog.json" | ||
expect_records: | ||
path: "integration_tests/expected_records.txt" | ||
extra_fields: no | ||
exact_order: no | ||
extra_records: yes | ||
incremental: | ||
- config_path: "secrets/config.json" | ||
configured_catalog_path: "integration_tests/configured_catalog.json" | ||
future_state_path: "integration_tests/future_state.json" | ||
tests: | ||
- config_path: "secrets/config.json" | ||
configured_catalog_path: "integration_tests/configured_catalog.json" | ||
future_state: | ||
future_state_path: "integration_tests/abnormal_state.json" | ||
full_refresh: | ||
- config_path: "secrets/config.json" | ||
configured_catalog_path: "integration_tests/configured_catalog.json" | ||
tests: | ||
- config_path: "secrets/config.json" | ||
configured_catalog_path: "integration_tests/configured_catalog.json" |
255 changes: 255 additions & 0 deletions
255
airbyte-integrations/connectors/source-prestashop/integration_tests/abnormal_state.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,255 @@ | ||
[ | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_descriptor": { | ||
"name": "addresses" | ||
}, | ||
"stream_state": { | ||
"date_upd": "2121-06-16 14:13:26" | ||
} | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_descriptor": { | ||
"name": "cart_rules" | ||
}, | ||
"stream_state": { | ||
"date_upd": "2121-06-16 14:13:26" | ||
} | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_descriptor": { | ||
"name": "carts" | ||
}, | ||
"stream_state": { | ||
"date_upd": "2121-06-16 14:13:26" | ||
} | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_descriptor": { | ||
"name": "categories" | ||
}, | ||
"stream_state": { | ||
"date_upd": "2121-06-16 14:13:26" | ||
} | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_descriptor": { | ||
"name": "configurations" | ||
}, | ||
"stream_state": { | ||
"date_upd": "2121-06-16 14:13:26" | ||
} | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_descriptor": { | ||
"name": "customer_messages" | ||
}, | ||
"stream_state": { | ||
"date_upd": "2121-06-16 14:13:26" | ||
} | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_descriptor": { | ||
"name": "customers" | ||
}, | ||
"stream_state": { | ||
"date_upd": "2121-06-16 14:13:26" | ||
} | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_descriptor": { | ||
"name": "customer_threads" | ||
}, | ||
"stream_state": { | ||
"date_upd": "2121-06-16 14:13:26" | ||
} | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_descriptor": { | ||
"name": "groups" | ||
}, | ||
"stream_state": { | ||
"date_upd": "2121-06-16 14:13:26" | ||
} | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_descriptor": { | ||
"name": "manufacturers" | ||
}, | ||
"stream_state": { | ||
"date_upd": "2121-06-16 14:13:26" | ||
} | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_descriptor": { | ||
"name": "messages" | ||
}, | ||
"stream_state": { | ||
"date_add": "2121-06-16 14:13:26" | ||
} | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_descriptor": { | ||
"name": "order_carriers" | ||
}, | ||
"stream_state": { | ||
"date_add": "2121-06-16 14:13:26" | ||
} | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_descriptor": { | ||
"name": "order_histories" | ||
}, | ||
"stream_state": { | ||
"date_add": "2121-06-16 14:13:26" | ||
} | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_descriptor": { | ||
"name": "order_invoices" | ||
}, | ||
"stream_state": { | ||
"date_add": "2121-06-16 14:13:26" | ||
} | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_descriptor": { | ||
"name": "order_payments" | ||
}, | ||
"stream_state": { | ||
"date_add": "2121-06-16 14:13:26" | ||
} | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_descriptor": { | ||
"name": "orders" | ||
}, | ||
"stream_state": { | ||
"date_upd": "2121-06-16 14:13:26" | ||
} | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_descriptor": { | ||
"name": "order_slip" | ||
}, | ||
"stream_state": { | ||
"date_upd": "2121-06-16 14:13:26" | ||
} | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_descriptor": { | ||
"name": "products" | ||
}, | ||
"stream_state": { | ||
"date_upd": "2121-06-16 14:13:26" | ||
} | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_descriptor": { | ||
"name": "stock_movement_reasons" | ||
}, | ||
"stream_state": { | ||
"date_upd": "2121-06-16 14:13:26" | ||
} | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_descriptor": { | ||
"name": "stock_movements" | ||
}, | ||
"stream_state": { | ||
"date_add": "2121-06-16 14:13:26" | ||
} | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_descriptor": { | ||
"name": "stores" | ||
}, | ||
"stream_state": { | ||
"date_upd": "2121-06-16 14:13:26" | ||
} | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_descriptor": { | ||
"name": "suppliers" | ||
}, | ||
"stream_state": { | ||
"date_upd": "2121-06-16 14:13:26" | ||
} | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_descriptor": { | ||
"name": "tax_rule_groups" | ||
}, | ||
"stream_state": { | ||
"date_upd": "2121-06-16 14:13:26" | ||
} | ||
} | ||
} | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you mean by docker setup? build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in really from previous developer
good catch I just removed it
it seems we don't need it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted back, we need it while docker containers with PrestaShop will up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's so special about this connector so it takes 5 minutes to go up? this is not a common issue, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.