Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: bring old set-output to build branch and artifact tags #18923

Merged
merged 1 commit into from
Nov 3, 2022
Merged

ci: bring old set-output to build branch and artifact tags #18923

merged 1 commit into from
Nov 3, 2022

Conversation

cuyk
Copy link
Contributor

@cuyk cuyk commented Nov 3, 2022

What

We have broken dev-{short_sha} tagging. Trying to fix it.

How

Bring old set-output GitHub Actions syntax

@cuyk cuyk temporarily deployed to more-secrets November 3, 2022 17:22 Inactive
@cuyk cuyk marked this pull request as ready for review November 3, 2022 17:23
@cuyk cuyk requested a review from supertopher November 3, 2022 17:23
supertopher
supertopher approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@supertopher supertopher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks for the quick work vova

@supertopher
Copy link
Contributor

@cuyk cuyk merged commit f488081 into master Nov 3, 2022
@cuyk cuyk deleted the vova/revert-github-output-to-test-broken-tagging branch November 3, 2022 17:27
@github-actions github-actions bot mentioned this pull request Nov 15, 2022
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Nov 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supertopher supertopher supertopher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cuyk @supertopher