🎉 New Source: Twitter [low-code cdk] #18863

bala-ceg · 2022-11-02T17:53:49Z

What

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

marcosmarxm

Hello @bala-ceg, Marcos from Airbyte here 👋 . We received more than 25 new contributions along the weekend. One is yours 🎉 thank so much for! Our team is limited and maybe the review process can take longer than expected. As described in the Airbyte's Hacktoberfest your contribution was submitted before November 2nd and it is eligible to win the prize. The review process will validate other requirements. I ask to you patience until someone from the team review it.

Because I reviewed some contributions for Hacktoberfest so far I saw some common patterns you can check in advance:

Make sure you have added connector documentation to /docs/integrations/
Remove the file catalog from /integration_tests
Edit the sample_config.json inside /integration_tests
For the configured_catalog you can use only json_schema: {}
Add title to all properties in the spec.yaml
Make sure the documentationUrl in the spec.yaml redirect to Airbyte's future connector page, eg: connector Airtable the documentationUrl: https://docs.airbyte.com/integrations/sources/airtable
Review now new line at EOF (end-of-file) for all files.

If possible send to me a DM in Slack with the tests credentials, this process will make easier to us run integration tests and publish your connector. If you only has production keys, make sure to create a bootstrap.md explaining how to get the keys.

marcosmarxm · 2022-11-04T08:56:28Z

Hello! I'm going to be out of the office this Friday and won't be able to review your contribution again today, I return next Monday. So far, most contributions look solid and are almost done to be approved. As said in Chris' comment all contributions made before 2-November are eligible to receive the prize and have 2 weeks to merge the contributions. But I ensure next week we're going to have your contribution merged. If you have questions about the implementation you can send them in #hacktoberfest-2022 in Airbyte's Slack.

Sorry the inconvenience and see you again next week, thank you so much for your contribution!

marcosmarxm

@bala-ceg this connector is ready to review?

bala-ceg · 2022-11-08T17:37:45Z

@marcosmarxm can i please get a day to get back with the changes?

marcosmarxm · 2022-11-08T17:38:37Z

@marcosmarxm can i please get a day to get back with the changes?

Of course! You have until 15-nov. Let me know if you need any assistance too.

bala-ceg · 2022-11-09T19:22:22Z

@marcosmarxm I added the missing elements of the checklist to my recent commit and my PR is ready for review and DM'ed you the test credentials

Make sure you have added connector documentation to /docs/integrations/
Remove the file catalog from /integration_tests
Edit the sample_config.json inside /integration_tests
For the configured_catalog you can use only json_schema: {}
Add title to all properties in the spec.yaml
Make sure the documentationUrl in the spec.yaml redirect to Airbyte's future connector page, eg: connector Airtable the documentationUrl: https://docs.airbyte.com/integrations/sources/airtable
Review now new line at EOF (end-of-file) for all files.

marcosmarxm

@bala-ceg please check my comment.

airbyte-integrations/connectors/source-twitter/source_twitter/twitter.yaml

marcosmarxm · 2022-11-16T13:58:19Z

/test connector=connectors/source-twitter

🕑 connectors/source-twitter https://github.com/airbytehq/airbyte/actions/runs/3479987411
✅ connectors/source-twitter https://github.com/airbytehq/airbyte/actions/runs/3479987411
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       133      3    98%   87, 93, 230
	 source_acceptance_test/conftest.py                     196     97    51%   35, 41-43, 48, 54, 60, 66, 72-74, 80-95, 100, 105-107, 113-115, 121-122, 127-128, 133, 139, 148-157, 163-168, 232, 238, 244-250, 258-263, 271-284, 289-295, 302-313, 320-336
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              329    106    68%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 377-379, 382, 447-455, 484-485, 491, 494, 530-540, 553-578
	 source_acceptance_test/tests/test_incremental.py       145     20    86%   21-23, 29-31, 36-43, 48-61, 224
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     10    87%   15-16, 24-30, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/config_migration.py        23     23     0%   5-37
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1479    376    75%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: This connector does not implement incremental sync
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:51: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:229: The previous connector image could not be retrieved.
======================== 24 passed, 3 skipped in 55.12s ========================

marcosmarxm · 2022-11-16T16:15:34Z

/publish connector=connectors/source-twitter

🕑 Publishing the following connectors:
connectors/source-twitter
https://github.com/airbytehq/airbyte/actions/runs/3481103817

Connector	Did it publish?	Were definitions generated?
connectors/source-twitter	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

marcosmarxm

Thanks @bala-ceg

* 🎉 New Source: Twitter * adhering to review checklist * adding stream slicer * adding stream slicer * add twitter to source def and run format * readd twitter to source def * correct twitter spec * run format * auto-bump connector version Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>

github-actions bot added the area/connectors Connector related issues label Nov 2, 2022

octavia-squidington-iv added bounty community connectors/source/twitter labels Nov 2, 2022

marcosmarxm added the hacktober label Nov 2, 2022

marcosmarxm requested changes Nov 2, 2022

View reviewed changes

marcosmarxm requested changes Nov 7, 2022

View reviewed changes

github-actions bot added the area/documentation Improvements or additions to documentation label Nov 9, 2022

bala-ceg requested a review from marcosmarxm November 10, 2022 02:12

marcosmarxm requested changes Nov 10, 2022

View reviewed changes

airbyte-integrations/connectors/source-twitter/source_twitter/twitter.yaml Outdated Show resolved Hide resolved

bala-ceg requested a review from marcosmarxm November 14, 2022 14:45

bala-ceg and others added 6 commits November 16, 2022 11:19

🎉 New Source: Twitter

88255c2

adhering to review checklist

ce2f0ad

adding stream slicer

e12611d

adding stream slicer

7432e0b

add twitter to source def and run format

7b87b3f

readd twitter to source def

0ed302a

marcosmarxm force-pushed the twitter branch from 85164f8 to 0ed302a Compare November 16, 2022 14:20

marcosmarxm added 2 commits November 16, 2022 13:04

correct twitter spec

209fa10

run format

a32d04b

octavia-squidington-iii and others added 2 commits November 16, 2022 16:35

auto-bump connector version

45721cb

Merge branch 'master' into twitter

ef67084

marcosmarxm approved these changes Nov 16, 2022

View reviewed changes

marcosmarxm merged commit 64cfb38 into airbytehq:master Nov 16, 2022

github-actions bot mentioned this pull request Nov 17, 2022

Bump helm chart version reference to 0.40.44 #19546

Merged

octavia-squidington-iii mentioned this pull request Nov 18, 2022

Bump Airbyte version from 0.40.18 to 0.40.19 #19579

Merged

marcosmarxm changed the title ~~🎉 New Source: Twitter~~ 🎉 New Source: Twitter [low-code cdk] Nov 18, 2022

sajarin added internal and removed bounty labels Dec 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 New Source: Twitter [low-code cdk] #18863

🎉 New Source: Twitter [low-code cdk] #18863

bala-ceg commented Nov 2, 2022 •

edited

Loading

marcosmarxm left a comment

marcosmarxm commented Nov 4, 2022

marcosmarxm left a comment

bala-ceg commented Nov 8, 2022

marcosmarxm commented Nov 8, 2022

bala-ceg commented Nov 9, 2022

marcosmarxm left a comment

marcosmarxm commented Nov 16, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 16, 2022 •

edited by github-actions bot

Loading

marcosmarxm left a comment

🎉 New Source: Twitter [low-code cdk] #18863

🎉 New Source: Twitter [low-code cdk] #18863

Conversation

bala-ceg commented Nov 2, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

marcosmarxm left a comment

Choose a reason for hiding this comment

marcosmarxm commented Nov 4, 2022

marcosmarxm left a comment

Choose a reason for hiding this comment

bala-ceg commented Nov 8, 2022

marcosmarxm commented Nov 8, 2022

bala-ceg commented Nov 9, 2022

marcosmarxm left a comment

Choose a reason for hiding this comment

marcosmarxm commented Nov 16, 2022 • edited by github-actions bot Loading

Build Passed

marcosmarxm commented Nov 16, 2022 • edited by github-actions bot Loading

marcosmarxm left a comment

Choose a reason for hiding this comment

bala-ceg commented Nov 2, 2022 •

edited

Loading

marcosmarxm commented Nov 16, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 16, 2022 •

edited by github-actions bot

Loading