MySQL Source: fixed unencrypted CDC connections #18851

VitaliiMaltsev · 2022-11-02T13:16:48Z

What

Fix for #18369
All CDC connections do not use the SSL protocol in the MySQL source code.

How

Updated DebeziumEngine setup with correct property for MySQL

Before

After

🚨 User Impact 🚨

none

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

VitaliiMaltsev · 2022-11-02T13:17:39Z

/test connector=connectors/source-mysql-strict-encrypt

🕑 connectors/source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3377858942
✅ connectors/source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3377858942
No Python unittests run

Build Passed

Test summary info:

All Passed

github-actions · 2022-11-02T13:17:44Z

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

Run integration tests
Bump connector version
Add changelog
Publish the new version

⚠ Sources (2)

Connector	Version	Changelog	Publish
`source-mysql`	`1.0.11`	✅	✅
`source-mysql-strict-encrypt`	`1.0.11`	✅	⚠ (not in seed)

See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)

Connector	Version	Changelog	Publish

See "Actionable Items" below for how to resolve warnings and errors.

Actionable Items

(click to expand)

Category	Status	Actionable Item
Version	❌ mismatch	The version of the connector is different from its normal variant. Please bump the version of the connector.
	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
Changelog	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
	❌ changelog missing	There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish	⚠ not in seed	The connector is not in the seed file (e.g. `source_definitions.yaml`), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
	❌ diff seed version	The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the `/publish` command to publish the latest version.

VitaliiMaltsev · 2022-11-02T13:17:49Z

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/3377860046
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/3377860046
No Python unittests run

Build Passed

Test summary info:

All Passed

subodh1810

Hah! typos leading to bugs!

VitaliiMaltsev · 2022-11-03T15:43:04Z

/publish connector=connectors/source-mysql-strict-encrypt

🕑 Publishing the following connectors:
connectors/source-mysql-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/3387128558

Connector	Did it publish?	Were definitions generated?
connectors/source-mysql-strict-encrypt	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

VitaliiMaltsev · 2022-11-03T15:43:28Z

/publish connector=connectors/source-mysql

🕑 Publishing the following connectors:
connectors/source-mysql
https://github.com/airbytehq/airbyte/actions/runs/3387131114

Connector	Did it publish?	Were definitions generated?
connectors/source-mysql	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

MySQL Source: fixed unencrypted CDC connections

bce8f7b

github-actions bot added the area/connectors Connector related issues label Nov 2, 2022

octavia-squidington-iv added the connectors/source/mysql label Nov 2, 2022

VitaliiMaltsev added 2 commits November 3, 2022 11:24

Merge branch 'master' into vmaltsev/18369-mysql-source-requre-ssl

c92d2d1

updated changelog

b7ae82c

github-actions bot added the area/documentation Improvements or additions to documentation label Nov 3, 2022

VitaliiMaltsev marked this pull request as ready for review November 3, 2022 09:35

VitaliiMaltsev requested a review from a team as a code owner November 3, 2022 09:35

VitaliiMaltsev requested review from bleonard and rodireich November 3, 2022 09:36

VitaliiMaltsev mentioned this pull request Nov 3, 2022

mysql CDC is not working when option user require ssl is enabled #18369

Closed

subodh1810 approved these changes Nov 3, 2022

View reviewed changes

bump version

fc1762a

octavia-squidington-iv added the connectors/source/mysql-strict-encrypt label Nov 3, 2022

auto-bump connector version

623d201

octavia-squidington-iii temporarily deployed to more-secrets November 3, 2022 17:37 Inactive

VitaliiMaltsev merged commit 8bb9701 into master Nov 3, 2022

VitaliiMaltsev deleted the vmaltsev/18369-mysql-source-requre-ssl branch November 3, 2022 17:40

github-actions bot mentioned this pull request Nov 15, 2022

Bump helm chart version reference to 0.40.43 #19453

Closed

octavia-squidington-iii mentioned this pull request Nov 18, 2022

Bump Airbyte version from 0.40.18 to 0.40.19 #19579

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MySQL Source: fixed unencrypted CDC connections #18851

MySQL Source: fixed unencrypted CDC connections #18851

VitaliiMaltsev commented Nov 2, 2022 •

edited

Loading

VitaliiMaltsev commented Nov 2, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Nov 2, 2022 •

edited

Loading

⚠ Sources (2)

✅ Destinations (0)

Actionable Items

VitaliiMaltsev commented Nov 2, 2022 •

edited by github-actions bot

Loading

subodh1810 left a comment

VitaliiMaltsev commented Nov 3, 2022 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Nov 3, 2022 •

edited by github-actions bot

Loading

MySQL Source: fixed unencrypted CDC connections #18851

MySQL Source: fixed unencrypted CDC connections #18851

Conversation

VitaliiMaltsev commented Nov 2, 2022 • edited Loading

What

How

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

VitaliiMaltsev commented Nov 2, 2022 • edited by github-actions bot Loading

Build Passed

github-actions bot commented Nov 2, 2022 • edited Loading

Affected Connector Report

⚠ Sources (2)

✅ Destinations (0)

Actionable Items

VitaliiMaltsev commented Nov 2, 2022 • edited by github-actions bot Loading

Build Passed

subodh1810 left a comment

Choose a reason for hiding this comment

VitaliiMaltsev commented Nov 3, 2022 • edited by github-actions bot Loading

VitaliiMaltsev commented Nov 3, 2022 • edited by github-actions bot Loading

VitaliiMaltsev commented Nov 2, 2022 •

edited

Loading

VitaliiMaltsev commented Nov 2, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Nov 2, 2022 •

edited

Loading

VitaliiMaltsev commented Nov 2, 2022 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Nov 3, 2022 •

edited by github-actions bot

Loading

VitaliiMaltsev commented Nov 3, 2022 •

edited by github-actions bot

Loading