Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show version and changelog status for affected connectors #18845

Merged
merged 21 commits into from
Nov 2, 2022
Merged

Show version and changelog status for affected connectors #18845

merged 21 commits into from
Nov 2, 2022

Conversation

tuliren
Copy link
Contributor

@tuliren tuliren commented Nov 2, 2022 •
edited
Loading

What

  • Update the connector dependency report to include more details about the affected connectors.

🚨 User Impact 🚨

  • It should be more clear on the PR whether a connector has been published or not.

@github-actions github-actions bot added the area/connectors Connector related issues label Nov 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022 •
edited
Loading

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector version
  • Add changelog
  • Publish the new version

❌ Sources (24)
Connector Version Changelog Publish
source-alloydb 1.0.17 ✅ ✅
source-alloydb-strict-encrypt 1.0.17 ✅ ⚠
(not in seed)
source-bigquery 0.2.2 ✅ ✅
source-clickhouse 0.1.14 ✅ ✅
source-clickhouse-strict-encrypt 0.1.14 ✅ ⚠
(not in seed)
source-cockroachdb 0.1.18 ✅ ✅
source-cockroachdb-strict-encrypt 0.1.18 ✅ ⚠
(not in seed)
source-db2 0.1.16 ✅ ✅
source-db2-strict-encrypt 0.1.16 ✅ ⚠
(not in seed)
source-jdbc 0.3.5 ⚠
(doc not found)		 ⚠
(not in seed)
source-mongodb-strict-encrypt 0.1.19 ⚠
(doc not found)		 ⚠
(not in seed)
source-mongodb-v2 0.1.19 ✅ ✅
source-mssql 0.4.24 ✅ ✅
source-mssql-strict-encrypt 0.4.24 ✅ ⚠
(not in seed)
source-mysql 1.0.10 ✅ ✅
source-mysql-strict-encrypt 1.0.10 ✅ ⚠
(not in seed)
source-oracle 0.3.21 ✅ ✅
source-oracle-strict-encrypt 0.3.21 ✅ ⚠
(not in seed)
source-postgres 1.0.23 ❌
(changelog missing)		 ❌
(diff seed version)
source-postgres-strict-encrypt ❌ 1.0.22
(mismatch: 1.0.23)		 ✅ ⚠
(not in seed)
source-redshift 0.3.14 ✅ ✅
source-scaffold-java-jdbc 0.1.0 ⚠
(doc not found)		 ⚠
(not in seed)
source-snowflake 0.1.24 ✅ ✅
source-tidb 0.2.1 ✅ ✅

✅ Destinations (0)
Connector Version Changelog Publish

Notes
Category Status Actionable Item
Version ❌
mismatch		 The version of the connector is different from its normal variant. Please bump the version of the connector.
⚠
doc not found		 The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog ⚠
doc not found		 The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
❌
changelog missing		 There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish ⚠
not in seed		 The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
❌
diff seed version		 The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version.

@tuliren tuliren temporarily deployed to more-secrets November 2, 2022 10:46 Inactive
@tuliren tuliren temporarily deployed to more-secrets November 2, 2022 11:05 Inactive
@tuliren tuliren temporarily deployed to more-secrets November 2, 2022 11:24 Inactive
@tuliren tuliren changed the title [WIP] Draft PR Show version and changelog status for affected connectors Nov 2, 2022
@tuliren tuliren temporarily deployed to more-secrets November 2, 2022 11:29 Inactive
@tuliren tuliren temporarily deployed to more-secrets November 2, 2022 11:31 Inactive
@tuliren tuliren temporarily deployed to more-secrets November 2, 2022 11:56 Inactive
@tuliren tuliren temporarily deployed to more-secrets November 2, 2022 12:00 Inactive
@tuliren tuliren force-pushed the liren/fancy-connector-report branch from 01d7e58 to dc2f13f Compare November 2, 2022 12:07
@tuliren tuliren temporarily deployed to more-secrets November 2, 2022 12:09 Inactive
@tuliren tuliren marked this pull request as ready for review November 2, 2022 15:12
@tuliren tuliren requested a review from a team as a code owner November 2, 2022 15:12
@tuliren tuliren requested a review from erohmensing November 2, 2022 15:12
@tuliren tuliren temporarily deployed to more-secrets November 2, 2022 16:32 Inactive
@tuliren tuliren temporarily deployed to more-secrets November 2, 2022 16:45 Inactive
@tuliren tuliren temporarily deployed to more-secrets November 2, 2022 18:05 Inactive
@github-actions github-actions bot removed the area/connectors Connector related issues label Nov 2, 2022
@tuliren tuliren temporarily deployed to more-secrets November 2, 2022 18:17 Inactive
@tuliren tuliren temporarily deployed to more-secrets November 2, 2022 18:20 Inactive
@tuliren tuliren temporarily deployed to more-secrets November 2, 2022 18:30 Inactive
@tuliren tuliren temporarily deployed to more-secrets November 2, 2022 18:39 Inactive
@tuliren tuliren merged commit 1dc6874 into master Nov 2, 2022
@tuliren tuliren deleted the liren/fancy-connector-report branch November 2, 2022 18:56
erohmensing
erohmensing reviewed Nov 2, 2022
View reviewed changes
Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such markdown mastery!

@tuliren tuliren mentioned this pull request Nov 3, 2022
Merged
letiescanciano added a commit that referenced this pull request Nov 3, 2022
@letiescanciano
Merge branch 'master' into leti/experiment-add-source-in-signup
2de8b3c 
* master: (38 commits)
  New Source: Gridly (#18342)
  🎉 New Source: Alpha Vantage (#18320)
  ci_integration_test.sh: cut GITHUB_STEP_SUMMARY (#18895)
  🎉 New Source: Datadog [python cdk] (#18150)
  Hide Reject all button in consent dialog (#18596)
  feat: add doc url to track event (#18690)
  fix: install java in oss catalog deploy action (#18887)
  [CI] Speed up check_images_exist (#18873)
  Extract open API (#18879)
  Remove unused interfaces (#18880)
  add action for deploying oss connector catalog to GCS (#18633)
  feat: generate full connector catalog json (#18562)
  Add unsupported_protocol_version column to Connection (#18876)
  Extract OAuth API (#18818)
  update images to have non-transparent background (#18874)
  DiscoverSchema endpoints calculates diff and breaking change (#18571)
  Validate protocol version on connector update (#18639)
  Bmoric/extract notification api (#18812)
  Show version and changelog status for affected connectors (#18845)
  Bmoric/extract logs api (#18621)
  ...
@github-actions github-actions bot mentioned this pull request Nov 15, 2022
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Nov 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erohmensing erohmensing erohmensing left review comments

Assignees
No one assigned
Labels
connectors/source/postgres connectors/source/relational-db
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuliren @erohmensing @octavia-squidington-iv