Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 New Source: Reply.io [low-code cdk] #18844

Merged
merged 7 commits into from
Nov 10, 2022

Conversation

elliottrabac
Copy link
Contributor

@elliottrabac elliottrabac commented Nov 2, 2022

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution
Implementing the Reply.io connector with relevant streams using the low Code CDK.

Recommended reading order

  1. reply_io.yaml
  2. spec.yaml

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

Screenshot 2022-11-07 at 21 40 16

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Nov 2, 2022
@elliottrabac elliottrabac marked this pull request as ready for review November 7, 2022 10:15
@elliottrabac
Copy link
Contributor Author

elliottrabac commented Nov 7, 2022

I forgot to mark it as ready for review

@RealChrisSean
Copy link

@marcosmarxm I was OOO for a few days and didn't have a chance to label this as hacktoberfest but this PR was submitted in time.

@marcosmarxm
Copy link
Member

@elliottrabac I'll review this contribution tomorrow.

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elliottrabac I'll publish later the connector

@marcosmarxm
Copy link
Member

marcosmarxm commented Nov 10, 2022

/test connector=connectors/source-reply-io

🕑 connectors/source-reply-io https://github.com/airbytehq/airbyte/actions/runs/3438499222
❌ connectors/source-reply-io https://github.com/airbytehq/airbyte/actions/runs/3438499222
🐛 https://gradle.com/s/waa5kvio2d7i4

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - docker.errors.Contai...
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:65: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:243: The previous connector image could not be retrieved.
=================== 2 failed, 22 passed, 3 skipped in 27.04s ===================

@marcosmarxm marcosmarxm force-pushed the elliot/new-reply-connector branch from 038dd44 to f8b26d7 Compare November 10, 2022 17:15
@marcosmarxm
Copy link
Member

marcosmarxm commented Nov 10, 2022

/publish connector=connectors/source-reply-io

🕑 Publishing the following connectors:
connectors/source-reply-io
https://github.com/airbytehq/airbyte/actions/runs/3439058279


Connector Did it publish? Were definitions generated?
connectors/source-reply-io

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@marcosmarxm marcosmarxm merged commit 69ac9b0 into airbytehq:master Nov 10, 2022
@marcosmarxm marcosmarxm changed the title 🎉 New Source: Reply.io 🎉 New Source: Reply.io [low-code cdk] Nov 18, 2022
akashkulk pushed a commit that referenced this pull request Dec 2, 2022
* configure connector

* add docs

* update PR number

* update acceptance tests

* add reply.io to source def

* add error handler and backoff strategy

* auto-bump connector version

Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
@sajarin sajarin added internal and removed bounty labels Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants