Connector builder test result display #18533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
Base automatically changed from
lmossman/connector-builder-testing-panel
to
master
October 28, 2022 05:39
lmossman
changed the title
timroes
reviewed
Nov 3, 2022
| } | ||
|
|
||
| function getSliceLabel(slice: StreamReadSlicesItem, sliceIndex: number) { | ||
| const fallback = `Slice ${sliceIndex}`; |
There was a problem hiding this comment.
We likely would still want to put this into a i18n call.
timroes
reviewed
Nov 3, 2022
Comment on lines
11
to
13
| // Not using arrow function due to generic type | ||
| // eslint-disable-next-line react/function-component-definition | ||
| function DefaultControlButton<T>({ selectedOption }: ListBoxControlButtonProps<T>) { |
There was a problem hiding this comment.
const DefaultControlButton = <T,>({ selectedOption }: ListBoxControlButtonProps<T>) => {Note the trailing comma behind the T is needed since this is a tsx file and otherwise the TS parser will think you're trying to open a JSX element in this case.
timroes
reviewed
Nov 3, 2022
|
|
||
| // Not using arrow function due to generic type | ||
| // eslint-disable-next-line react/function-component-definition | ||
| export function ListBox<T>(props: ListBoxProps<T>) { |
There was a problem hiding this comment.
Same as above to keep with our const style.
timroes
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolves #18559
Implements the results display in the connector builder testing panel, to bring it closer to the design
Screenshot of what the app looks like on this branch:
How
This PR mainly deals with displaying slices and pages of results properly.
It generifies the StreamSelector Headless UI Listbox implementation into a reusable ListBox component, as it is now used to implement a dropdown to select the stream as well as the slice.
Also adds a component that wraps to add a page control at the bottom of the screen.
Uses headless UI to also implement tabs to view either Records, Request, or Response.