🎉 New Destination: Apache Doris #17884

catpineapple · 2022-10-12T11:57:55Z

What

Add destination doris

How

destination-doris is a destination implemented based on Doris stream load,
It works as follows:
1: read stream and write a temp csv file.
2: make a http put request to pre-commit this csv file.
3: make a http request commit this transaction .

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Acceptance

Put your acceptance tests output here.

marcosmarxm · 2022-10-12T17:53:36Z

@catpineapple how are you running the integration tests? do you have a local Apache Doris running? Can you add the setup to use a docker container?

catpineapple · 2022-10-13T03:11:45Z

build this docker image :airbyte/destination-doris:dev , then add this destination at localhost:8000 -> settings -> destinations -> +new connecter.
installed an apache doris (1be+1fe). and create target database and tables.
New connection: make a sources read File(csv) ,and make a doris destination ( settings: Host,Port,Database,user,password).

run task,sync data.

marcosmarxm · 2022-10-13T23:43:12Z

Can you add the setup of docker container to automate tests? Doing manual tests aren't viable.

harshithmullapudi · 2022-10-17T14:54:11Z

Hey @marcosmarxm did you mean add the creation of database in the testing suite in itself?

marcosmarxm · 2022-10-18T23:33:02Z

Yes.

marcosmarxm · 2022-10-25T18:22:29Z

build this docker image :airbyte/destination-doris:dev , then add this destination at localhost:8000 -> settings -> destinations -> +new connecter.

installed an apache doris (1be+1fe). and create target database and tables.

New connection: make a sources read File(csv) ,and make a doris destination ( settings: Host,Port,Database,user,password).

run task,sync data.

Can you add a bootstrap.md how to do this process? I don't have knowledge about Apache Doris and setup the tool is not trivial. We must have this documentation to show people how to be able to test locally and probably improve in the future.

marcosmarxm · 2022-10-28T20:43:00Z

@catpineapple can you check Yugabytedb destination implementation. It uses a docker-compose setup to spin-up containers to run tests automatically. Let me know what do you think about implementing it for Apache Doris.

catpineapple · 2022-11-03T06:19:46Z

Is there any documentation to guide me to do this, I don't quite understand what kind of test this is. @marcosmarxm

catpineapple · 2022-11-03T06:23:03Z

@catpineapple can you check Yugabytedb destination implementation. It uses a docker-compose setup to spin-up containers to run tests automatically. Let me know what do you think about implementing it for Apache Doris.

Sorry for my foolish, please list as many areas as possible that I need to improve, the current way is too inefficient @marcosmarxm

marcosmarxm · 2022-11-04T08:36:44Z

Hello! Your PR is approved but didn't have the time to publish and merge it this week. As you can check in Chris' comment all PRs submitted before 2-nov are eligible to win the prize. I'll be out of the office on Friday and return Monday to start publishing your contribution. Any question you can send a message in #hacktoberfest-2022 channel in Airbyte's Slack.

Have a good weekend and thank you for this amazing contribution for Hacktoberfest 🎉

catpineapple · 2022-11-11T14:05:12Z

@marcosmarxm hi，I would like to inquire about the merge progress of this pull request
and Have a nice weekend

marcosmarxm · 2022-11-14T23:51:35Z

/publish connector=connectors/destination-doris run-tests=false

🕑 Publishing the following connectors:
connectors/destination-doris
https://github.com/airbytehq/airbyte/actions/runs/3466155872

Connector	Did it publish?	Were definitions generated?
connectors/destination-doris	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

marcosmarxm

Thanks @catpineapple sorry the delay to merge this amazing contribution :)

RealChrisSean · 2022-11-18T07:44:22Z

Hello @catpineapple ! Can you please provide the best email to contact you about payouts. Thank you!

catpineapple · 2022-11-18T08:32:58Z

Hello @catpineapple ! Can you please provide the best email to contact you about payouts. Thank you!

@RealChrisSean my email is 1391869588@qq.com

* first commit * normalized code and integration test * add bootstrap.md * add doris to destination def * auto-bump connector version * format files Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

catpineapple · 2023-11-22T07:06:45Z

Hello @catpineapple ! Can you please provide the best email to contact you about payouts. Thank you!

hi, @RealChrisSean I remembered this incident recently, is there any further information?

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 12, 2022

octavia-squidington-iv added bounty community connectors/destination/doris labels Oct 12, 2022

sajarin added internal team/destinations Destinations team's backlog labels Oct 12, 2022

octavia-squidington-iv removed the bounty label Oct 12, 2022

sajarin changed the title ~~Add a new destination : destination doris~~ 🎉 New Destination: Doris Oct 12, 2022

marcosmarxm changed the title ~~🎉 New Destination: Doris~~ 🎉 New Destination: Apache Doris Oct 12, 2022

marcosmarxm added the hacktober label Oct 19, 2022

RealChrisSean mentioned this pull request Oct 21, 2022

New Destination: Apache Doris airbytehq/connector-contest#173

Closed

catpineapple and others added 4 commits November 14, 2022 20:51

first commit

3d2f903

normalized code and integration test

0f9e5e3

add bootstrap.md

d335275

add doris to destination def

21514d4

marcosmarxm force-pushed the add_doris branch from 1ad5f99 to 21514d4 Compare November 14, 2022 23:51

auto-bump connector version

915f357

format files

73df9d2

marcosmarxm approved these changes Nov 15, 2022

View reviewed changes

marcosmarxm merged commit 241cf4a into airbytehq:master Nov 15, 2022

RealChrisSean added the python Pull requests that update Python code label Nov 15, 2022

github-actions bot mentioned this pull request Nov 15, 2022

Bump helm chart version reference to 0.40.43 #19453

Closed

octavia-squidington-iii mentioned this pull request Nov 18, 2022

Bump Airbyte version from 0.40.18 to 0.40.19 #19579

Merged

catpineapple deleted the add_doris branch December 1, 2022 03:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 New Destination: Apache Doris #17884

🎉 New Destination: Apache Doris #17884

catpineapple commented Oct 12, 2022 •

edited

Loading

marcosmarxm commented Oct 12, 2022

catpineapple commented Oct 13, 2022

marcosmarxm commented Oct 13, 2022

harshithmullapudi commented Oct 17, 2022

marcosmarxm commented Oct 18, 2022

marcosmarxm commented Oct 25, 2022

marcosmarxm commented Oct 28, 2022

catpineapple commented Nov 3, 2022

catpineapple commented Nov 3, 2022

marcosmarxm commented Nov 4, 2022 •

edited

Loading

catpineapple commented Nov 11, 2022 •

edited

Loading

marcosmarxm commented Nov 14, 2022 •

edited by github-actions bot

Loading

marcosmarxm left a comment

RealChrisSean commented Nov 18, 2022

catpineapple commented Nov 18, 2022 •

edited

Loading

catpineapple commented Nov 22, 2023 •

edited

Loading

🎉 New Destination: Apache Doris #17884

🎉 New Destination: Apache Doris #17884

Conversation

catpineapple commented Oct 12, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

marcosmarxm commented Oct 12, 2022

catpineapple commented Oct 13, 2022

marcosmarxm commented Oct 13, 2022

harshithmullapudi commented Oct 17, 2022

marcosmarxm commented Oct 18, 2022

marcosmarxm commented Oct 25, 2022

marcosmarxm commented Oct 28, 2022

catpineapple commented Nov 3, 2022

catpineapple commented Nov 3, 2022

marcosmarxm commented Nov 4, 2022 • edited Loading

catpineapple commented Nov 11, 2022 • edited Loading

marcosmarxm commented Nov 14, 2022 • edited by github-actions bot Loading

marcosmarxm left a comment

Choose a reason for hiding this comment

RealChrisSean commented Nov 18, 2022

catpineapple commented Nov 18, 2022 • edited Loading

catpineapple commented Nov 22, 2023 • edited Loading

catpineapple commented Oct 12, 2022 •

edited

Loading

marcosmarxm commented Nov 4, 2022 •

edited

Loading

catpineapple commented Nov 11, 2022 •

edited

Loading

marcosmarxm commented Nov 14, 2022 •

edited by github-actions bot

Loading

catpineapple commented Nov 18, 2022 •

edited

Loading

catpineapple commented Nov 22, 2023 •

edited

Loading