Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start testing buildpulse. #17712

Merged
merged 8 commits into from
Oct 9, 2022
Merged

Start testing buildpulse. #17712

merged 8 commits into from
Oct 9, 2022

Conversation

davinchia
Copy link
Contributor

@davinchia davinchia commented Oct 7, 2022

What

Buildpulse.io is a tool for detecting flaky tests that integrates well with GHA. Flaky tests are something we want to start figuring out more of.

This PR starts pushing platform tests to buildpulse so we can start trialing out this tool.

The idea is to try this out for a couple of weeks (enough time to see if this tool actually can detect flaky tests) and decide if this serves our needs.

How

Start a buildpulse trial.

Recommended reading order

The one file.

🚨 User Impact 🚨

No breaking changes.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@davinchia
Copy link
Contributor Author

davinchia commented Oct 7, 2022

/test connector=destination-dynamodb

🕑 destination-dynamodb https://github.com/airbytehq/airbyte/actions/runs/3202215696
✅ destination-dynamodb https://github.com/airbytehq/airbyte/actions/runs/3202215696
No Python unittests run

Build Passed

Test summary info:

All Passed

@davinchia davinchia temporarily deployed to more-secrets October 7, 2022 04:17 Inactive
@davinchia davinchia temporarily deployed to more-secrets October 7, 2022 05:16 Inactive
@davinchia davinchia temporarily deployed to more-secrets October 7, 2022 16:44 Inactive
@davinchia davinchia temporarily deployed to more-secrets October 7, 2022 17:35 Inactive
@davinchia davinchia temporarily deployed to more-secrets October 8, 2022 00:00 Inactive
@davinchia davinchia changed the title Test buildpulse. Start testing buildpulse. Oct 9, 2022
@davinchia davinchia temporarily deployed to more-secrets October 9, 2022 21:33 Inactive
@davinchia davinchia marked this pull request as ready for review October 9, 2022 21:34
@davinchia davinchia temporarily deployed to more-secrets October 9, 2022 21:36 Inactive
@davinchia
Copy link
Contributor Author

davinchia commented Oct 9, 2022

fyi @airbytehq/production-engineering @cgardens @malikdiarra @gosusnp @jdpgrailsdev all of which have expressed interest in this

@grishick I'm also looking at trialing this with the connector tests in a follow up PR

@davinchia davinchia requested a review from git-phu October 9, 2022 21:38
@davinchia davinchia merged commit 719cd55 into master Oct 9, 2022
@davinchia davinchia deleted the davinchia/test-buildpulse branch October 9, 2022 21:41
letiescanciano added a commit that referenced this pull request Oct 10, 2022
…vation

* master: (22 commits)
  Update full-refresh-append.md (#17784)
  Update full-refresh-overwrite.md (#17783)
  Update incremental-append.md (#17785)
  Update incremental-deduped-history.md (#17786)
  Update cdc.md (#17787)
  🪟 🔧 Ignore classnames during jest snapshot comparison (#17773)
  feat: replace openjdk with amazoncorretto:17.0.4 on connectors for seсurity compliance (#17511)
  Start testing buildpulse. (#17712)
  Add missing types to the registry (#17763)
  jobs db descriptions (#16543)
  config db data catalog (#16427)
  Update lowcode docs (#17752)
  db migrations to support new webhook operations (#17671)
  Bump Airbyte version from 0.40.13 to 0.40.14 (#17762)
  September Release Notes (#17754)
  Revert "Use java-datadog-tracer-base image (#17625)" (#17759)
  Add connection migrations for schema changes (#17651)
  Connection Form Refactor - Part Two (#16748)
  Improve E2E testing around the Connection Form (#17577)
  Bump strict encrypt version (#17747)
  ...
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
Buildpulse.io is a tool for detecting flaky tests that integrates well with GHA. Flaky tests are something we want to start figuring out more of.

This PR starts pushing platform tests to buildpulse so we can start trialing out this tool.

The idea is to try this out for a couple of weeks (enough time to see if this tool actually can detect flaky tests) and decide if this serves our needs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants