🪟 🐛 Fixes connector checks not properly ending their loading state #17620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
timroes
commented
Oct 5, 2022
| @@ -42,11 +42,12 @@ const SourceSettings: React.FC<SourceSettingsProps> = ({ currentSource, connecti | |||
| name: string; | |||
| serviceType: string; | |||
| connectionConfiguration?: ConnectionConfiguration; | |||
| }) => | |||
| }) => { | |||
There was a problem hiding this comment.
ℹ️ Needed so this method does return Promise<void> and not the result from updateSource.
timroes
changed the title
krishnaglick
approved these changes
Oct 5, 2022
krishnaglick
reviewed
Oct 5, 2022
lmossman
approved these changes
Oct 5, 2022
This was referenced Oct 5, 2022
letiescanciano
added a commit
that referenced
this pull request
Oct 6, 2022
…vation * master: (26 commits) supply a source id for schema discovery in connector integration tests (#17662) Source Iterable: Add permission check for stream (#17602) Moving TrackingClientSingleton.initialize into the bean itself (#17631) Handle null workspace IDs in tracking/reporting methods gracefully (#17641) Bump Airbyte version from 0.40.11 to 0.40.12 (#17653) Revert "Do not wait the end of a reset to return an update (#17591)" (#17640) Standardize HttpRequester's url_base and path format (#17524) Create geography_type enum and add geography column in connection and workspace table (#16818) airbyte-cron: update connector definitions from remote (#16438) Do not wait the end of a reset to return an update (#17591) Remove redundant title labels from connector specs (#17544) Updated GA4 status support large schema discovery (#17394) 🪟 🐛 Fixes connector checks not properly ending their loading state (#17620) 🪟🧪 [Experiment] add hideOnboarding experiment (#17605) Source Recharge: change releaseStage to GA (#17606) Source Recharge: skip stream if 403 received (#17608) remove sonar-scan workflow (#17609) Mark/tables should be full width on all pages (#17401) Auto fail all workfow if there is a Versioning issue (#17562) ...
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
…irbytehq#17620) * Fixes connector checks not properly ending their loading state * Fix properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes https://github.com/airbytehq/oncall/issues/747
Our types around this method were broken in a way, that causes those functions to actually be
asyncand require theawaithere despite TypeScript thinking it shouldn't be async methods.To test: Please make sure that setting up connectors with wrong data properly shows the error in the UI and isn't stuck in an infinite loading bar.