Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable normalization skip when no new data #17574

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Disable normalization skip when no new data #17574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d22fcf
Disable normalization skip when no new data
gosusnp Oct 4, 2022
d1d80fb
Disable irrelevant tests
gosusnp Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions airbyte-workers/src/main/java/io/airbyte/workers/temporal/sync/SyncWorkflowImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,10 @@ public StandardSyncOutput run(final JobRunConfig jobRunConfig,
shouldRun = true;
}
if (!shouldRun) {
LOGGER.info("Skipping normalization because there are no records to normalize.");
continue;
LOGGER.info("No records to normalize detected");
// Normalization skip has been disabled: issue #5417
// LOGGER.info("Skipping normalization because there are no records to normalize.");
// continue;
}
}

Expand Down
2 changes: 2 additions & 0 deletions airbyte-workers/src/test/java/io/airbyte/workers/temporal/sync/SyncWorkflowTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
import org.apache.commons.lang3.tuple.ImmutablePair;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

@SuppressWarnings({"PMD.UnusedPrivateField", "PMD.UnusedPrivateMethod"})
Expand Down Expand Up @@ -312,6 +313,7 @@ void testCancelDuringNormalization() {
}

@Test
@Disabled("This behavior has been disabled temporarily (OC Issue #741)")
void testSkipNormalization() throws IOException {
final SyncStats syncStats = new SyncStats().withRecordsCommitted(0L);
final StandardSyncSummary standardSyncSummary = new StandardSyncSummary().withTotalStats(syncStats);
Expand Down