-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🪟 🎉 Add integration for Osano/GDPR #17565
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not test locally, code LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also did not test locally, but looks good to me 👍
"Europe/Vilnius", | ||
"Europe/Warsaw", | ||
"Europe/Zagreb", | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious: is browser timezone a sufficient way to enforce GDPR? Seems a bit unreliable to me, but I don't have a better suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, this is not a really foolproof way. Luckily this is really only used to determine the default state of the newsletter flag and such I think it's an "okay enough" approach, without requiring to get a third party geo location service in place (which would be the better approach detecting by IP location). Osano itself for showing the right consent banner actually uses a proper IP based approach, so it's really only for the default state of this one switch we're needing to use this weaker approach.
What
Closing https://github.com/airbytehq/airbyte-cloud/issues/2426
This adds the full implementation for GDPR and Osano into the product. It will address the following:
production
) and thus show the consent dialogs.