-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
source-bing-ads: migrate to per-stream state #17386
source-bing-ads: migrate to per-stream state #17386
Conversation
/test connector=connectors/source-bing-ads
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Nice find on the need to fix the way account was represented in the JSON. It's interesting that this was working in the first place since integers as a key are not considered valid JSON, so somewhere along the way we were translating the int to a str before persisting.
Also attaching a thread for more context on what was being observed during Pedro's OC.
https://airbytehq-team.slack.com/archives/C02TL38U5L7/p1663347369570809
airbyte-integrations/connectors/source-bing-ads/integration_tests/state.json
Outdated
Show resolved
Hide resolved
/publish connector=connectors/source-bing-ads run-tests=false
if you have connectors that successfully published but failed definition generation, follow step 4 here |
What
We want source-bing-ads to use the latest CDK version.
How
accountId
key types in states (castint
tostr
)