Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compilation error with cursor type method #16635

Merged
merged 2 commits into from
Sep 13, 2022
Merged

fix compilation error with cursor type method #16635

merged 2 commits into from
Sep 13, 2022

Conversation

subodh1810
Copy link
Contributor

no issue for this, my PR had a compilation error

@subodh1810 subodh1810 self-assigned this Sep 13, 2022
@subodh1810 subodh1810 requested a review from a team as a code owner September 13, 2022 12:49
@subodh1810
Copy link
Contributor Author

subodh1810 commented Sep 13, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/3045195542
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/3045195542
No Python unittests run

Build Passed

Test summary info:

All Passed

@github-actions github-actions bot added the area/connectors Connector related issues label Sep 13, 2022
@subodh1810
Copy link
Contributor Author

subodh1810 commented Sep 13, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/3045196177
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/3045196177
No Python unittests run

Build Passed

Test summary info:

All Passed

@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-postgres-strict-encrypt
  • source-clickhouse
  • source-clickhouse-strict-encrypt
  • source-mssql-strict-encrypt
  • source-cockroachdb
  • source-scaffold-java-jdbc
  • source-oracle
  • source-db2
  • source-oracle-strict-encrypt
  • source-tidb
  • source-mongodb-v2
  • source-mysql-strict-encrypt
  • source-bigquery
  • source-mongodb-strict-encrypt
  • source-redshift
  • source-cockroachdb-strict-encrypt
  • source-alloydb
  • source-mssql
  • source-jdbc
  • source-postgres
  • source-db2-strict-encrypt
  • source-snowflake
  • source-mysql

@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-redshift
  • source-postgres
  • source-oracle-strict-encrypt
  • source-cockroachdb-strict-encrypt
  • source-mysql-strict-encrypt
  • source-clickhouse
  • source-mongodb-strict-encrypt
  • source-scaffold-java-jdbc
  • source-cockroachdb
  • source-alloydb
  • source-mongodb-v2
  • source-mssql-strict-encrypt
  • source-jdbc
  • source-postgres-strict-encrypt
  • source-db2
  • source-clickhouse-strict-encrypt
  • source-snowflake
  • source-tidb
  • source-oracle
  • source-mssql
  • source-bigquery
  • source-db2-strict-encrypt
  • source-mysql

@subodh1810 subodh1810 merged commit 59dd5e7 into master Sep 13, 2022
@subodh1810 subodh1810 deleted the fix-compilation-error-cursor-type branch September 13, 2022 15:57
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Sep 13, 2022
Merged
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
@subodh1810 @robbinhan
fix compilation error with cursor type method (airbytehq#16635)
32067bb 
* fix compilation error with cursor type method

* fix error for bigquery as well
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@subodh1810 @jhammarstedt
fix compilation error with cursor type method (airbytehq#16635)
f697448 
* fix compilation error with cursor type method

* fix error for bigquery as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VitaliiMaltsev VitaliiMaltsev VitaliiMaltsev approved these changes

Assignees

@subodh1810 subodh1810

Labels
area/connectors Connector related issues connectors/source/bigquery connectors/source/jdbc connectors/source/relational-db
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@subodh1810 @VitaliiMaltsev @octavia-squidington-iii