Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Twilio: shift start date for stream if it exceeds 400 days #15972

Merged
merged 5 commits into from
Aug 29, 2022

Conversation

roman-yermilov-gl
Copy link
Contributor

What

Fix a retention window by shifting start date to the earliest possible point but no more than 400 days before now

Recommended reading order

  1. x.java
  2. y.python

@lazebnyi lazebnyi linked an issue Aug 26, 2022 that may be closed by this pull request
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Aug 26, 2022
@roman-yermilov-gl
Copy link
Contributor Author

roman-yermilov-gl commented Aug 26, 2022

/test connector=connectors/source-twilio

🕑 connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/2933787382
❌ connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/2933787382
🐛 https://gradle.com/s/2l4mwas5b5duu

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_additional_properties_is_true[inputs0] - ...
FAILED test_core.py::TestDiscovery::test_additional_properties_is_true[inputs0]
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Please check...
=================== 3 failed, 29 passed in 243.27s (0:04:03) ===================

@roman-yermilov-gl roman-yermilov-gl requested review from bazarnov and lazebnyi and removed request for grubberr, davydov-d and arsenlosenko August 26, 2022 12:48
@roman-yermilov-gl
Copy link
Contributor Author

roman-yermilov-gl commented Aug 29, 2022

/test connector=connectors/source-twilio

🕑 connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/2947988434
✅ connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/2947988434
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_twilio/auth.py           8      0   100%
source_twilio/__init__.py       2      0   100%
source_twilio/source.py        28      9    68%
source_twilio/streams.py      240     89    63%
-----------------------------------------------
TOTAL                         278     98    65%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-216
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1322    463    65%

Build Passed

Test summary info:

All Passed

@roman-yermilov-gl
Copy link
Contributor Author

roman-yermilov-gl commented Aug 29, 2022

/publish connector=connectors/source-twilio

🕑 Publishing the following connectors:
connectors/source-twilio
https://github.com/airbytehq/airbyte/actions/runs/2949030440


Connector Did it publish? Were definitions generated?
connectors/source-twilio

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@bazarnov bazarnov merged commit d999ba1 into master Aug 29, 2022
@bazarnov bazarnov deleted the ryermilov/source-twilio-400-client-error branch August 29, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Twilio: 400 Client Error when syncing Massages table
4 participants