🪟 Updates to credits page #15756
Merged
🪟 Updates to credits page #15756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natalyjazzviolin
added
area/platform
lmossman
approved these changes
Aug 18, 2022
| </Suspense> | ||
| </MainView> | ||
| </MainInfo> | ||
| <CreditsUsagePage /> |
There was a problem hiding this comment.
nit: should this component be renamed to something like CreditsUsage, since it is no longer being considered as a "separate page", but instead just a part of the CreditsPage?
There was a problem hiding this comment.
@lmossman That's a really good point, thank you!
rodireich
pushed a commit
that referenced
this pull request
Aug 25, 2022
* Removes side menu. * Removes conditional rendering that is no longer needed. * Adds bottom margin to the Remaining Credits block. * Renames credit usage component as per request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes https://github.com/airbytehq/airbyte-cloud/issues/2308
Part of https://github.com/airbytehq/airbyte-cloud/issues/2130
Removes the 'Credit Usage' side menu on the /credits page.
Before:
After:
How
Removes the side menu component and conditional rendering for it. Adjusts bottom margin for the 'Remaining Credits' block.
Reading order
CreditsPage.tsRemainingCredits.tsx