Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include a list of available timezones for cron string scheduling #15666

Merged
merged 2 commits into from
Aug 17, 2022

Conversation

mfsiega-airbyte
Copy link
Contributor

What

Include a list of available timezones for cron string scheduling in the frontend.

How

  • Added a log line in the server (which does the validation) to dump the available IDs in JSON
  • Removed the Etc/ timezones, which we specifically filter out
  • Pasted the output into the frontend package

Recommended reading order

  1. airbyte-webapp/src/config/AvailableTimeZones.json

🚨 User Impact 🚨

No

@mfsiega-airbyte mfsiega-airbyte requested a review from a team as a code owner August 15, 2022 16:21
@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Aug 15, 2022
@mfsiega-airbyte
Copy link
Contributor Author

This is the lightest-weight solution to unblock frontend work on the scheduling UX.

Some additional possible testing:

  • Put this file in some common location between server and webapp
  • Add a test in the server package that checks that every timezone in the list is still available.

This can either be added to this PR or done in a follow-up.

Further possible step: generate the list dynamically in the build process.

@timroes
Copy link
Contributor

timroes commented Aug 16, 2022

Could we maybe name the file lowercase. Despite some other files in this folder, this is kind of the standard we're going for, if it's not a component/class.

Also maybe we can include that it's about cron, e.g. availableCronTimeZones.json?

@mfsiega-airbyte
Copy link
Contributor Author

Updated, please take a look!

Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mfsiega-airbyte mfsiega-airbyte merged commit b885c4e into master Aug 17, 2022
@mfsiega-airbyte mfsiega-airbyte deleted the msiega/cronstrings branch August 17, 2022 14:38
rodireich pushed a commit that referenced this pull request Aug 25, 2022
)

* include a list of available timezones for cron string scheduling in the frontend

* rename available cron timezone config file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants