Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🔧 Convert Markdown.styles.scss to module #15646

Merged
merged 2 commits into from
Aug 15, 2022
Merged

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Aug 15, 2022

What

Converts the Markdown.styles.scss file into a SCSS module.

This uses now module generated class names for the markdown component itself as well as the admonition plugin.

Note: This was originally not made a module, because we wanted to have actual untouched class names in the output. This can be achieved in a SCSS module, by wrapping the class names in :global, i.e.:

.markdown :global(.admonition) {
  // creates a scrambled name for .markdown, but keep .admonition untouched
}

cc @edmundito

@timroes timroes requested a review from a team as a code owner August 15, 2022 08:31
@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Aug 15, 2022
@timroes timroes changed the title Convert Markdown.styles.scss to module 🪟 🧹 Convert Markdown.styles.scss to module Aug 15, 2022
@timroes timroes changed the title 🪟 🧹 Convert Markdown.styles.scss to module 🪟 🔧 Convert Markdown.styles.scss to module Aug 15, 2022
Copy link
Contributor

@edmundito edmundito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think of approaching it this way because before I fixed some issues with the code tag there were other class names being used. This makes sense now!

I did not test this locally.

@timroes timroes merged commit 7584c1d into master Aug 15, 2022
@timroes timroes deleted the tim/scss-module branch August 15, 2022 13:16
rodireich pushed a commit that referenced this pull request Aug 20, 2022
* Convert Markdown.styles.scss to module

* Split scss  modules for better linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants