Experimentally hide the Name and Company Name fields on the signup page #15622
Conversation
github-actions
bot
added
area/platform
| "authPage.signup.hideName": boolean; | ||
| "authPage.signup.hideCompanyName": boolean; |
There was a problem hiding this comment.
👍🏼 Easier to set up experiments if hide is set to true over show set to false
| "authPage.signup.hideCompanyName" | ||
| ); | ||
|
|
||
| const SignupPageValidationSchema = yup.object().shape({ |
There was a problem hiding this comment.
var name should be camel case, not sure why it was pascal case in the first place.
| const { hideField: hideName, fieldSchema: nameSchema } = useExperimentallyHiddenField("authPage.signup.hideName"); | ||
| const { hideField: hideCompanyName, fieldSchema: companyNameSchema } = useExperimentallyHiddenField( | ||
| "authPage.signup.hideCompanyName" | ||
| ); |
There was a problem hiding this comment.
Might be simpler to set the validation schema as a memo, for example:
const hideName = useExperiment("authPage.signup.hideName", false);
const validationSchema = useMemo(() => {
const shape = { /* the initial values */ };
if (!hideCompanyName) shape.name = yup.string();
return yup.object().(shape);
}, [hideCompanyName]);There was a problem hiding this comment.
Thanks for the suggestion! I think this approach is a lot simpler
| <NameField /> | ||
| <CompanyNameField /> | ||
| </RowFieldItem> | ||
| {(!hideName || !hideCompanyName) && ( |
There was a problem hiding this comment.
Another possible way to avoid checking for nots so often. Positive can be easier to read.
const showName = !useExperiement("authPage.signup.hideName", false);
There was a problem hiding this comment.
Yeah it was starting to feel like too many nots, so what you suggested is probably a better approach
That is correct! |
lmossman
deleted the
lmossman/experimentally-hide-name-and-company-name
branch
…ge (#15622) * Experimentally hide the Name and Company Name fields on the signup page * refactor validation schema
What
Resolves https://github.com/airbytehq/airbyte-cloud/issues/1430
How
This PR adds logic to hide the Full Name and Company Name fields on the signup page based on respective feature flags in LaunchDarkly.
When these fields are hidden, users will be created with empty strings set for both the name and company name columns on the user record. The backend handles this gracefully, and in the case of an empty company name it uses the email as the name of the workspace created for the new user.
Example screenshot of the signup page with both fields set to hidden in LaunchDarkly:
