Remove automaticMigrationAcceptanceTest
#15418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evantahler
changed the title
testAutomaticMigrationtestAutomaticMigration
evantahler
changed the title
testAutomaticMigrationtestAutomaticMigration
evantahler
changed the title
testAutomaticMigrationautomaticMigrationAcceptanceTest
evantahler
changed the title
automaticMigrationAcceptanceTest automaticMigrationAcceptanceTest
davinchia
approved these changes
Aug 8, 2022
There was a problem hiding this comment.
I'm okay with disabling the test. Deleting the test is okay with me as long as we make sure we have some follow up.
One reasonable path forward we discussed was an issue to test the case of 'the latest minor version should always be upgradable to this latest dev version i.e. ./gradlew build`.
cgardens
reviewed
Aug 9, 2022
There was a problem hiding this comment.
- Testing back to 0.17.0 is probably not useful at this point.
- I do think that having some sanity check that we are able to upgrade from version X to version Y is useful. It is something that I think is worth having an acceptance test for because there is a little more to the migration than just running a flyway migration.
- Do we know which part is flakey? If the part from 0.32.0 to current is solid, then I would keep that. If the flake is somewhere in these, then I would be in favor of figuring out how to reenable.
So I would be in favor of reducing the scope of the test to more modern versions of airbyte, but still having some sort of acceptance test.
evantahler
force-pushed
the
evan/disableTestAutomaticMigration
branch
from
977f06f to
177596b
Compare
|
Something happened with this PR... Github got very mad when I force-pushed... recreating |
|
#15497 has the modified/simpler test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is currently very flaky and breaking the build
After a chat with @davinchia, we don't feel that this test is providing much value, so we are comfortable disabling it for now to get the build green.
In general, now that we use Flyaway for migrations, what is the benefit of this test? If there are particularly complex migrations in which we modify data, having a unit test makes sense for that migration, but testing that our migrations work all the way back to X version (v0.17.0 in this case) seems to be like we are testing the migration engine itself, and isn't necessary. If we trust our migration engine, and each incremental migration, we should be in a safe place.
Reviewers: In the comments below, please let us know what you think about removing this test entirely, or should we just disable it for now until we can solve the flakiness?