-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destination S3: add LZO compression support #15394
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
979fe1f
Fixed bucket naming for S3
VitaliiMaltsev 7d2963a
Merge branch 'master' of https://github.com/airbytehq/airbyte
VitaliiMaltsev e921180
Merge branch 'master' of https://github.com/airbytehq/airbyte
VitaliiMaltsev 0e6f7df
Merge branch 'master' of https://github.com/airbytehq/airbyte
VitaliiMaltsev dcc5801
Destination S3: add LZO compression support for parquet files
VitaliiMaltsev 53af6c4
Destination S3: add LZO compression support for parquet files
VitaliiMaltsev 7924657
Merge branch 'master' of https://github.com/airbytehq/airbyte
VitaliiMaltsev 33f012b
implemented logic for aarch64
VitaliiMaltsev 4bd4b6b
removed redundant logging
VitaliiMaltsev 1d48487
updated changelog
VitaliiMaltsev 717a298
moved intstall of native-lzo lib to Dockerfile
VitaliiMaltsev 92ddb73
removed redundant logging
VitaliiMaltsev 09a17e8
add unit test for aarch64
VitaliiMaltsev b5c1106
Merge branch 'master' of https://github.com/airbytehq/airbyte
VitaliiMaltsev c454cb7
Merge branch 'master' into vmaltsev/destination-s3-lzo-parquet
VitaliiMaltsev 843557e
bump version
VitaliiMaltsev 257d981
auto-bump connector version [ci skip]
octavia-squidington-iii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
...ation-s3/src/main/java/io/airbyte/integrations/destination/s3/util/JavaProcessRunner.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
/* | ||
* Copyright (c) 2022 Airbyte, Inc., all rights reserved. | ||
*/ | ||
|
||
package io.airbyte.integrations.destination.s3.util; | ||
|
||
import io.airbyte.commons.io.LineGobbler; | ||
import java.io.File; | ||
import java.io.IOException; | ||
import java.util.Arrays; | ||
import java.util.concurrent.TimeUnit; | ||
import org.slf4j.Logger; | ||
import org.slf4j.LoggerFactory; | ||
|
||
public class JavaProcessRunner { | ||
|
||
private static final Logger LOGGER = LoggerFactory.getLogger(JavaProcessRunner.class); | ||
|
||
public static void runProcess(final String path, final Runtime run, final String... commands) throws IOException, InterruptedException { | ||
LOGGER.info("Running process: " + Arrays.asList(commands)); | ||
final Process pr = path.equals(System.getProperty("user.dir")) ? run.exec(commands) : run.exec(commands, null, new File(path)); | ||
LineGobbler.gobble(pr.getErrorStream(), LOGGER::error); | ||
LineGobbler.gobble(pr.getInputStream(), LOGGER::info); | ||
if (!pr.waitFor(10, TimeUnit.MINUTES)) { | ||
pr.destroy(); | ||
throw new RuntimeException("Timeout while executing: " + Arrays.toString(commands)); | ||
} | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to install these dependencies in the test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unit tests does not use builded destination-s3 image