Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 Add Segment call for Connection Delete #15365

Merged
merged 2 commits into from
Aug 5, 2022
Merged

🪟 Add Segment call for Connection Delete #15365

merged 2 commits into from
Aug 5, 2022

Conversation

dizel852
Copy link
Contributor

@dizel852 dizel852 commented Aug 5, 2022

What

Closes #13863

How

Add segment call for Connection Delete action

Request body example:
Screenshot at Aug 05 16-39-09

Recommended reading order

  1. useConnectionHook.tsx
  2. SettingsView.tsx
  3. ConnectionItemPage.tsx

@dizel852 dizel852 requested a review from a team as a code owner August 5, 2022 13:48
@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Aug 5, 2022
teallarson
teallarson approved these changes Aug 5, 2022
View reviewed changes
Copy link
Contributor

@teallarson teallarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Tested locally by deleting a connection.

@dizel852 dizel852 merged commit dfed48b into master Aug 5, 2022
@dizel852 dizel852 deleted the vlad/13863-segment-call-for-connection-delete branch August 5, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teallarson teallarson teallarson approved these changes

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Segment call for Connection Delete
2 participants
@dizel852 @teallarson