-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate sendgrid to config-based #15257
Conversation
$ref: "*ref(requester)" | ||
path: "/v3/marketing/contacts" | ||
paginator: | ||
type: "NoPagination" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
contacts pagination has been deprecated https://docs.sendgrid.com/api-reference/contacts/get-sample-contacts
$ref: "*ref(requester)" | ||
path: "/v3/marketing/segments" | ||
paginator: | ||
type: "NoPagination" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
segments does not support pagination https://docs.sendgrid.com/api-reference/segmenting-contacts/get-list-of-segments#
$ref: "*ref(requester)" | ||
path: "/v3/asm/groups" | ||
paginator: | ||
type: "NoPagination" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ref: "*ref(offset_paginator)" | ||
stream_slicer: | ||
$ref: "*ref(stream_slicer)" | ||
blocks_stream: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test account contains no records for blocks stream
/test connector=connectors/source-sendgrid
Build FailedTest summary info:
|
@@ -0,0 +1,331 @@ | |||
page_size: 50 | |||
|
|||
schema_loader: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an advice here is that you should have a top level definitions
where you can create your reusable objects. Right now it is polluting the top level "namespace" and that will make it harder to extend it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that could be a part of the spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes! done
|
||
schema_loader: | ||
type: JsonSchema | ||
file_path: "./source_sendgrid/schemas/{{ options.name }}.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about calling it values
instead of options
, since semantically they are just values and not really configuration options?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed. keeping track of this issue here
/test connector=connectors/source-sendgrid |
/test connector=connectors/source-sendgrid
Build FailedTest summary info:
|
/test connector=connectors/source-greenhouse
Build FailedTest summary info:
|
/test connector=connectors/source-sendgrid
Build PassedTest summary info:
|
/test connector=connectors/source-sendgrid
Build PassedTest summary info:
|
/test connector=connectors/source-sendgrid
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment on end & start dates, they should be dynamic
inject_into: "path" | ||
pagination_strategy: | ||
type: "CursorPagination" | ||
cursor_value: "{{ response._metadata.next }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no stop condition?
end_datetime: | ||
datetime: "2022-08-01T00:00:00.0Z" | ||
datetime_format: "%Y-%m-%dT%H:%M:%S.%f%z" | ||
step: "10000d" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like a pretty huge step size no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to 30d
end_datetime: | ||
datetime: "2022-08-01T00:00:00.0Z" | ||
datetime_format: "%Y-%m-%dT%H:%M:%S.%f%z" | ||
step: "10000d" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
datetime: "2017-01-01T00:00:00.0Z" | ||
datetime_format: "%Y-%m-%dT%H:%M:%S.%f%z" | ||
end_datetime: | ||
datetime: "2022-08-01T00:00:00.0Z" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
datetime: "2017-01-01T00:00:00.0Z" | ||
datetime_format: "%Y-%m-%dT%H:%M:%S.%f%z" | ||
end_datetime: | ||
datetime: "2022-08-01T00:00:00.0Z" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we shouldn't hardcode this right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
/test connector=connectors/source-sendgrid
Build PassedTest summary info:
|
/publish connector=connectors/source-sendgrid
if you have connectors that successfully published but failed definition generation, follow step 4 here |
/test connector=connectors/source-sendgrid |
What
Migrate the sendgrid connector to config-based
How
YamlDeclarativeSource
Recommended reading order
airbyte-integrations/connectors/source-sendgrid/source_sendgrid/sendgrid.yaml
airbyte-integrations/connectors/source-sendgrid/source_sendgrid/source.py
airbyte-integrations/connectors/source-sendgrid/source_sendgrid/spec.json
airbyte-integrations/connectors/source-sendgrid/unit_tests/unit_test.py
airbyte-integrations/connectors/source-sendgrid/setup.py
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.