Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial and documentation for config-based connectors #15027
Tutorial and documentation for config-based connectors #15027
Changes from 9 commits
4855a72
138bd52
637c2a7
9fabad8
ff775e3
6ebee74
ff2b602
906f915
a64c758
2099b24
8bab845
a03e6f3
d444d74
71e0a5b
a9512ab
7b36ca6
218bfd9
78599e3
c9bfb99
58567c5
76a95ae
8feb1a6
ecf9b34
990d44a
f9b1b68
945cc3e
a3349df
318e613
c54b0c4
9cc1e4b
f096296
8bd35b4
cfb4528
85d5afb
61a75b5
7e1dc95
3df5071
b074832
672eb16
6575c9d
e747b4a
d5ac31d
fdce2c6
198b421
18bc40f
f4e5ed4
83e3845
bab017b
37d1fde
1fc83fe
6944916
c317a49
096a370
ff804be
49be031
6790422
34214b4
bf9a205
74e4de8
ca0f93c
46b2ee4
9cfd223
65a966c
dd4437c
365c0dc
ebaa701
aacc30a
3b1e85f
b4498f3
306e9e5
c2d9b86
562844b
faada9a
08487f7
30d25c0
63a295c
019cc0a
117ee2f
3a00dac
b2040fc
db243a8
cc0d76c
6cbdaa0
619bf37
9a4f1c9
5337868
e4919d5
e27fade
048bddb
019aad2
cc308f2
e3cffc8
785a3e4
2db7694
2a7d5fc
eba0322
e7f0023
8353121
e6637d3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think something which would be great to have somewhere (not sure if this page is the right place, but seems like the most natural) is the motivation for this framework. Something like the "All APIs are the same" section in the PRD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CDK does technically support a pk, list of pks, and even a list of nested lists of pks. Is it our intention to lock this down to just a single string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated with full type definition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also support a list of cursor field strings. I'm thinking Maybe we just get rid of "A ..." and just start with Cursor field(s), Checkpoint Interval, Schema, etc. Also a nit, but capitalizing the first letter after the
:
tends to be better grammar.Schema: Describes the data to sync
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed