-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Greg/guykoh update dbt clickhouse #14897
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi we can actually run CI against community branches directly now. E.g. #14485
/test connector=connectors/destination-clickhouse
Build PassedTest summary info:
|
/test connector=connectors/destination-snowflake
Build PassedTest summary info:
|
/publish connector=bases/base-normalization
if you have connectors that successfully published but failed definition generation, follow step 4 here |
/test connector=bases/base-normalization
Build FailedTest summary info:
|
7289356
to
dbb93a6
Compare
/test connector=bases/base-normalization
Build FailedTest summary info:
|
/test connector=bases/base-normalization
Build FailedTest summary info:
|
/test connector=bases/base-normalization
Build FailedTest summary info:
|
/test connector=bases/base-normalization
Build FailedTest summary info:
|
@@ -293,6 +293,7 @@ def transform_clickhouse(config: Dict[str, Any]): | |||
# https://docs.getdbt.com/reference/warehouse-profiles/clickhouse-profile | |||
dbt_config = { | |||
"type": "clickhouse", | |||
"driver": "clickhouse-connect", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a valid value for 'driver' field - use 'native'. In fact, you don't need that field at all, the connector will derive the driver protocol from the port (9440).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hrm. will try setting it explicitly - integration tests were failing because driver was being set to None
:
1 check failed:
dbt was unable to connect to the specified database.
The database returned the following error:
>Database Error
Library for ClickHouse driver type None not found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran the tests locally and ran into this error:
14:29:05 Compilation Error in model dedup_exchange_rate_ab1 (models/generated/airbyte_ctes/test_normalization/dedup_exchange_rate_ab1.sql)
14:29:05 No materialization 'ignore' was found for adapter clickhouse! (searched types 'default' and 'clickhouse')
Maybe the approach here is be to use either view materialization, or materialize as tables and then drop the tables afterward, unless I'm misunderstanding the intent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, let's use view materialization instead.
/test connector=bases/base-normalization
Build FailedTest summary info:
|
/test connector=bases/base-normalization
Build FailedTest summary info:
|
372f97b
to
3eb3b7a
Compare
/test connector=bases/base-normalization
Build FailedTest summary info:
|
/test connector=bases/base-normalization
Build FailedTest summary info:
|
ccb430c
to
9d818b0
Compare
/test connector=bases/base-normalization
Build FailedTest summary info:
Build FailedTest summary info:
|
b3cdbf9
to
e4964b9
Compare
/test connector=bases/base-normalization
Build PassedTest summary info:
|
/test connector=connectors/destination-clickhouse
Build PassedTest summary info:
|
e4964b9
to
6fe668d
Compare
6fe668d
to
bd2dd4a
Compare
/publish connector=bases/base-normalization
if you have connectors that successfully published but failed definition generation, follow step 4 here |
* Update dbt-clickhouse version to 1.1.7 to support AirByte on ClickHouse cloud * Fix quote handling in Clickhouse normalization tests * Update test output for Clickhouse * Bump version and update changelog Co-authored-by: guykohen <guy@clickhouse.com>
What
Update dbt-clickhouse version to support Airbyte on ClickHouse cloud
This is an internal PR to run CI for this contributor PR