Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Zendesk Support: Convert tickets.custom_fields values to string #14829

Merged
merged 9 commits into from
Jul 22, 2022
Merged

Source Zendesk Support: Convert tickets.custom_fields values to string #14829

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ebb488f
extend schema for tickets
grubberr Jul 19, 2022
1943955
Merge branch 'master' into grubberr/oncall-320-source-zendesk-support
grubberr Jul 21, 2022
d53fd2c
parse "custom_fields"
grubberr Jul 21, 2022
5dabf9f
zendesk-support.md updated
grubberr Jul 21, 2022
12d1133
Merge branch 'master' into grubberr/oncall-320-source-zendesk-support
grubberr Jul 21, 2022
1790c27
test_read_tickets_stream added
grubberr Jul 21, 2022
3494f98
Merge branch 'master' into grubberr/oncall-320-source-zendesk-support
grubberr Jul 21, 2022
ce659be
use transformer
grubberr Jul 21, 2022
7b2c98a
auto-bump connector version [ci skip]
octavia-squidington-iii Jul 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-zendesk-support/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@ COPY source_zendesk_support ./source_zendesk_support
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.2.12
LABEL io.airbyte.version=0.2.13
LABEL io.airbyte.name=airbyte/source-zendesk-support
7 changes: 7 additions & 0 deletions airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,6 +475,13 @@ class Tickets(SourceZendeskIncrementalExportStream):

response_list_name: str = "tickets"

def parse_response(self, response: requests.Response, **kwargs) -> Iterable[Mapping]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason not to use the TypeTransformer here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to use TypeTransformer!

for record in super().parse_response(response, **kwargs):
for field in record.get("custom_fields", []):
if field["value"] is not None:
field["value"] = str(field["value"])
yield record


class TicketComments(SourceZendeskSupportTicketEventsExportStream):
"""
Expand Down
3 changes: 2 additions & 1 deletion docs/integrations/sources/zendesk-support.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ The Zendesk connector ideally should not run into Zendesk API limitations under

| Version | Date | Pull Request | Subject |
|:---------|:-----------|:---------------------------------------------------------|:-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| `0.2.12` | 2022-06-30 | [14304](https://github.com/airbytehq/airbyte/pull/14304) | Fixed Pagination for Group Membership stream|
| `0.2.13` | 2022-07-21 | [14829](https://github.com/airbytehq/airbyte/pull/14829) | Convert `tickets.custom_fields` values to string |
| `0.2.12` | 2022-06-30 | [14304](https://github.com/airbytehq/airbyte/pull/14304) | Fixed Pagination for Group Membership stream |
| `0.2.11` | 2022-06-24 | [14112](https://github.com/airbytehq/airbyte/pull/14112) | Fixed "Retry-After" non integer value |
| `0.2.10` | 2022-06-14 | [13757](https://github.com/airbytehq/airbyte/pull/13757) | Fixed the bug with `TicketMetrics` stream, HTTP Error 429, caused by lots of API requests |
| `0.2.9` | 2022-05-27 | [13261](https://github.com/airbytehq/airbyte/pull/13261) | Bugfix for the unhandled [ChunkedEncodingError](https://github.com/airbytehq/airbyte/issues/12591) and [ConnectionError](https://github.com/airbytehq/airbyte/issues/12155) |
Expand Down