Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mssql connector #14649

Closed
wants to merge 1 commit into from
Closed

Bump mssql connector #14649

wants to merge 1 commit into from

Conversation

benmoriceau
Copy link
Contributor

What

Bump the connector version to make sure that the state lifecycle manager is included.

@benmoriceau benmoriceau requested a review from a team as a code owner July 12, 2022 21:57
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jul 12, 2022
@benmoriceau
Copy link
Contributor Author

benmoriceau commented Jul 12, 2022

/test connector=connectors/destination-mssql

🕑 connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/2659854239
✅ connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/2659854239
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     155      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         162     34    79%
normalization/transform_catalog/utils.py                             38      9    76%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 570    377    34%
-------------------------------------------------------------------------------------
TOTAL                                                              1363    587    57%

Build Passed

Test summary info:

All Passed

@grishick
Copy link
Contributor

@benmoriceau have you tested this upgrade scenario:

  1. a full refresh is created with a connector that is not aware of state lifecycle manager (e.g. version before this one)
  2. an incremental refresh is run with a connector that is not aware of state lifecycle manager
  3. connector is upgraded to this version
  4. an incremental sync runs and does not fail

@@ -115,6 +115,7 @@ Using this feature requires additional configuration, when creating the source.

| Version | Date | Pull Request | Subject |
|:--------| :--- |:---------------------------------------------------------|:----------------------------------------------------------------------------------------------------|
| 0.1.20 | 2022-07-12 | [14649](https://github.com/airbytehq/airbyte/pull/14649) | Include lifecycle management |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

State Lifecycle management?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It refers to #13670.

@benmoriceau
Copy link
Contributor Author

No

@benmoriceau have you tested this upgrade scenario:

  1. a full refresh is created with a connector that is not aware of state lifecycle manager (e.g. version before this one)
  2. an incremental refresh is run with a connector that is not aware of state lifecycle manager
  3. connector is upgraded to this version
  4. an incremental sync runs and does not fail

@grishick No, I'm gonna try to do it.

@benmoriceau
Copy link
Contributor Author

No

@benmoriceau have you tested this upgrade scenario:

  1. a full refresh is created with a connector that is not aware of state lifecycle manager (e.g. version before this one)
  2. an incremental refresh is run with a connector that is not aware of state lifecycle manager
  3. connector is upgraded to this version
  4. an incremental sync runs and does not fail

@grishick No, I'm gonna try to do it.

@grishick I tested it locally and it worked, I'll publish once I have your approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/mssql
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants