Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "additionalProperties": false from specs for connectors with staging #14114

Merged
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
"oneOf": [
{
"title": "Standard Inserts",
"additionalProperties": false,
"required": ["method"],
"properties": {
"method": {
Expand All @@ -42,7 +41,6 @@
},
{
"title": "GCS Staging",
"additionalProperties": false,
"type": "object",
"required": [
"method",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@
"oneOf": [
{
"title": "Standard Inserts",
"additionalProperties": false,
"required": ["method"],
"properties": {
"method": {
Expand All @@ -81,7 +80,6 @@
},
{
"title": "GCS Staging",
"additionalProperties": false,
"required": [
"method",
"gcs_bucket_name",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
"title": "GCS Destination Spec",
"type": "object",
"required": ["gcs_bucket_name", "gcs_bucket_path", "credential", "format"],
"additionalProperties": false,
"properties": {
"gcs_bucket_name": {
"title": "GCS Bucket Name",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@
"oneOf": [
{
"title": "Standard",
"additionalProperties": false,
"required": ["method"],
"properties": {
"method": {
Expand All @@ -66,7 +65,6 @@
},
{
"title": "S3 Staging",
"additionalProperties": false,
"required": [
"method",
"s3_bucket_name",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
"s3_bucket_region",
"format"
],
"additionalProperties": false,
"properties": {
"access_key_id": {
"type": "string",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,6 @@
"oneOf": [
{
"title": "Select another option",
"additionalProperties": false,
"description": "Select another option",
"required": ["method"],
"properties": {
Expand All @@ -147,7 +146,6 @@
},
{
"title": "[Recommended] Internal Staging",
"additionalProperties": false,
"description": "Writes large batches of records to a file, uploads the file to Snowflake, then uses <pre>COPY INTO table</pre> to upload the file. Recommended for large production workloads for better speed and scalability.",
"required": ["method"],
"properties": {
Expand All @@ -162,7 +160,6 @@
},
{
"title": "AWS S3 Staging",
"additionalProperties": false,
"description": "Writes large batches of records to a file, uploads the file to S3, then uses <pre>COPY INTO table</pre> to upload the file. Recommended for large production workloads for better speed and scalability.",
"required": [
"method",
Expand Down Expand Up @@ -287,7 +284,6 @@
},
{
"title": "GCS Staging",
"additionalProperties": false,
"description": "Writes large batches of records to a file, uploads the file to GCS, then uses <pre>COPY INTO table</pre> to upload the file. Recommended for large production workloads for better speed and scalability.",
"required": [
"method",
Expand Down Expand Up @@ -330,7 +326,6 @@
},
{
"title": "Azure Blob Storage Staging",
"additionalProperties": false,
"description": "Writes large batches of records to a file, uploads the file to Azure Blob Storage, then uses <pre>COPY INTO table</pre> to upload the file. Recommended for large production workloads for better speed and scalability.",
"required": [
"method",
Expand Down