Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉Source-postgres: added custom JDBC parameters (jdbc_url_params) field #12840

Merged
merged 5 commits into from
May 17, 2022
Merged

🎉Source-postgres: added custom JDBC parameters (jdbc_url_params) field #12840

merged 5 commits into from
May 17, 2022

Conversation

etsybaev
Copy link
Contributor

@etsybaev etsybaev commented May 13, 2022 •
edited
Loading

What

User was not able to set additional property

How

Introduced new optional field on UI
Selection_191

🚨 User Impact 🚨

No breaking changes expected

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

@github-actions github-actions bot added the area/connectors Connector related issues label May 13, 2022
@etsybaev etsybaev linked an issue May 13, 2022 that may be closed by this pull request
Source Postgres: custom JDBC parameters #10729
Closed
@etsybaev etsybaev changed the title [10729] source-postgres: added custom JDBC parameters field 🎉Source-postgres: added custom JDBC parameters (jdbc_url_params) field May 14, 2022
@etsybaev
Copy link
Contributor Author

etsybaev commented May 14, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2323443765
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2323443765
No Python unittests run

@etsybaev etsybaev requested a review from alexandr-shegeda May 14, 2022 10:37
alexandr-shegeda
alexandr-shegeda approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@alexandr-shegeda alexandr-shegeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. we can proceed with publishing and merging without airbyte review

@alexandr-shegeda alexandr-shegeda marked this pull request as ready for review May 16, 2022 14:42
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label May 16, 2022
@etsybaev
Copy link
Contributor Author

etsybaev commented May 17, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2337739890
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2337739890
No Python unittests run

@etsybaev
Copy link
Contributor Author

etsybaev commented May 17, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2338162734
🚀 Successfully published connectors/source-postgres
🚀 Auto-bumped version for connectors/source-postgres
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2338162734

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets May 17, 2022 12:46 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets May 17, 2022 12:46 Inactive
@etsybaev etsybaev merged commit c85e131 into master May 17, 2022
@etsybaev etsybaev deleted the etsybaev/10729-postgres-source-added-custom-jdbc-parameters-field branch May 17, 2022 12:51
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request May 20, 2022
Merged
suhomud pushed a commit that referenced this pull request May 23, 2022
@etsybaev @suhomud
🎉Source-postgres: added custom JDBC parameters (jdbc_url_params) field (
4c0e9ca 
#12840)

* [10729] source-postgres: added custom JDBC parameters field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandr-shegeda alexandr-shegeda alexandr-shegeda approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source Postgres: custom JDBC parameters
3 participants
@etsybaev @alexandr-shegeda @octavia-squidington-iii